New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NativeImageLoader on Android #5468

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
3 participants
@saudet
Copy link
Member

saudet commented Jun 5, 2018

Makes sure to write back changes with Indexer.release() when not using direct indexers, as on Android.

I also updated the unit tests to also use non-direct indexers, and they pass only after the changes.

/cc @jrmerwin @johanvos

@saudet saudet requested a review from AlexDBlack Jun 5, 2018

@saudet saudet force-pushed the sa_image branch from 0d74060 to 2773f1a Jun 5, 2018

@AlexDBlack
Copy link
Member

AlexDBlack left a comment

I can't really comment on the fix or android-specific stuff, but sure, LGTM :)

@saudet saudet merged commit e5b4859 into master Jun 5, 2018

1 of 2 checks passed

codeclimate 4 issues to fix
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@johanvos

This comment has been minimized.

Copy link
Contributor

johanvos commented Jun 5, 2018

I tested this on Android, and it works indeed as expected now. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment