New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI model update #6190

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@raver119
Copy link
Contributor

raver119 commented Aug 17, 2018

  • ParallelInference now able to update model in runtime
  • fix for bad import in LSTMHelpers

cc @agibsonccc

- ParallelInference now able to update model in runtime
- fix for bad import in LSTMHelpers

@raver119 raver119 requested a review from agibsonccc Aug 17, 2018

@raver119

This comment has been minimized.

Copy link
Contributor

raver119 commented Aug 17, 2018

Model update works, but i think that we should probably check actual nIn, and if it doesn't match new model - we should notify user about that, or, just gracefully reinit PI

@raver119 raver119 merged commit 5e9a4da into master Aug 17, 2018

1 check was pending

codeclimate Code Climate is analyzing this code.
Details

@raver119 raver119 deleted the r119_pi_update branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment