New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converters between org.nd4j.linalg.primitives.Pair/Triple and scala Tuple #6323

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@zorba128
Copy link
Contributor

zorba128 commented Aug 31, 2018

Provides converters between nd4j's tuples and scala tuples.
Names to be decided - as proposed (asScala - as in scala.collection.JavaConverters) or maybe toScala
or toTuple.

Matter of taste.

Converters between org.nd4j.linalg.primitives.Pair/Triple and scala T…
…uple2/Tuple3.

Names to be decided - as proposed, or maybe toScala or toTuple

@zorba128 zorba128 referenced this pull request Aug 31, 2018

Open

ND4S - tuples mapping #6317

@saudet saudet requested a review from maxpumperla Sep 1, 2018

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Sep 10, 2018

Ping @maxpumperla - does this look OK to you?

@maxpumperla

This comment has been minimized.

Copy link
Contributor

maxpumperla commented Sep 10, 2018

@zorba128 sorry I missed this, very useful utility functionality. thanks for this contribution!

@maxpumperla
Copy link
Contributor

maxpumperla left a comment

LGTM

@maxpumperla maxpumperla merged commit faf3d8e into deeplearning4j:master Sep 10, 2018

0 of 2 checks passed

codeclimate Code Climate is analyzing this code.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment