Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changed DataSet.merge signature #6424
This small PR addresses an immediate problem I had : getRange returns an api.DataSet, which is logical since getRange is inherited from api.DataSet interface. But DataSet.merge only takes a list of DataSet.
However, there is a deeper design problem : api.DataSet references DataSet, which ruins the point of having a separate interface. I think one of the two following actions must be taken:
These remarks about the api/implementation split hold for DataSet, but may hold for others, I didn't check.