New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Apache Lucene/Solr version from 7.4.0 to 7.5.0 #6485

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@cpoerschke
Copy link
Contributor

cpoerschke commented Sep 25, 2018

http://lucene.apache.org/core/7_5_0/changes/Changes.html
http://lucene.apache.org/solr/7_5_0/changes/Changes.html

The lucene-solr.version pom.xml property is currently used by two modules:

  • deeplearning4j/deeplearning4j-dataimport-solrj
  • deeplearning4j/deeplearning4j-modelexport-solr
upgrade Apache Lucene/Solr version from 7.4.0 to 7.5.0
http://lucene.apache.org/core/7_5_0/changes/Changes.html
http://lucene.apache.org/solr/7_5_0/changes/Changes.html

The lucene-solr.version pom.xml property is currently used by two modules:
* deeplearning4j/deeplearning4j-dataimport-solrj
* deeplearning4j/deeplearning4j-modelexport-solr
@cpoerschke

This comment has been minimized.

Copy link
Contributor

cpoerschke commented Oct 3, 2018

@AlexDBlack @agibsonccc @raver119 @saudet @sshepel

Hello. Would one of you have an opportunity to review this small pull request here sometime this week perhaps? It is the last (known) blocker for the #5429 feature pull request, and well it's an artificial target but I'd love to try and perhaps wrap that one up before the Activate, The Search & AI Conference which is October 15-18. What do you think? Hopefully the version upgrade here at least is uncontroversial, #5744 was the previous version upgrade pull request. Thanks!

@saudet

This comment has been minimized.

Copy link
Member

saudet commented Oct 4, 2018

It seems fine to me, let's merge? @agibsonccc

@agibsonccc agibsonccc merged commit 93ad128 into deeplearning4j:master Oct 4, 2018

1 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@cpoerschke cpoerschke deleted the cpoerschke:master-upgrade-to-lucene-solr-7.5.0 branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment