[WIP] Some memory improvements #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new method for memory tracking
- constant tracking
stolsvik
reviewed
Dec 21, 2018
| @@ -6488,7 +6488,7 @@ public void close() throws Exception { | |||
| return; | |||
|
|
|||
| if (!closeable()) | |||
| throw new ND4JIllegalStateException("Can't release view array"); | |||
| throw new ND4JIllegalStateException("Can't release this INDArray"); | |||
There was a problem hiding this comment.
Would be great to know why it is not closeable.
stolsvik
reviewed
Dec 21, 2018
| for (val r:references) | ||
| r.markReleased(); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| if (!closeable()) | ||
| throw new IllegalStateException("Can't release this data buffer"); |
There was a problem hiding this comment.
Would be great to know why it is not closeable.
printomi
pushed a commit
to printomi/deeplearning4j
that referenced
this pull request
Jan 7, 2019
* initial commit * not closeable for IsAttached() * couple of simple tests * one more test * CUDA backend * batched_gemm additional validation * normalize_moments same mode fix * - varargs for few Nd4j.createFromArray signatures - new method for memory tracking * one more test * one more test * workspace attached * one more test * - legacy tracking - constant tracking * cpu constant space * minor tweaks * important pico fix * cpu workspace tracking * separate tracking for workspace allocations * temporary ignored test pack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
- GC handling improvements for CUDA backend