Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shugeo bug3 #6906

Merged
merged 7 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@shugeo
Copy link
Contributor

commented Dec 19, 2018

Fixed reduce_* and reduce_*_bp ops to use "dynamic" axis and bool flags.

All tests for fixes also provided.

@raver119 raver119 merged commit 0ddbd98 into master Dec 19, 2018

1 of 2 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@raver119 raver119 deleted the shugeo_bug3 branch Dec 19, 2018

printomi added a commit to printomi/deeplearning4j that referenced this pull request Jan 7, 2019

Shugeo bug3 (deeplearning4j#6906)
* Fixed axes and bool params for reduce_dot/min/max ops.

* Fixed norm1 and norm1_bp reducing ops.

* Fixed reduce norms and reduce_prod.

* Fixed reduce_sum and reduce_sum_bp to use proper axis.

* Fixed reduce_*_bp ops and tests.

* Fixed some ops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.