Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLP fixes and weight table serialization #7219

Merged
merged 9 commits into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@alexanderst
Copy link
Contributor

commented Feb 22, 2019

What changes were proposed in this pull request?

  1. Fixed wrong counter for subsequent training runs.
  2. Fixed broken test.
  3. Added text serialization for weight lookup table.

How was this patch tested?

Unit tests.

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files).

@raver119 raver119 merged commit 55727e5 into master Feb 22, 2019

0 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/jenkins/pr-head This commit has test failures
Details

@raver119 raver119 deleted the asto_NLP_fixes branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.