Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ncorrect calculating for False Positive Rate in EvaluationBinary class #7313

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@dariuszzbyrad
Copy link
Contributor

commented Mar 19, 2019

What changes were proposed in this pull request?

Fixed incorrect calculating for False Positive Rate in EvaluationBinary class (org.nd4j.evaluation.classification.EvaluationBinary#falsePositiveRate(int))

https://github.com/deeplearning4j/deeplearning4j/issues/7312

How was this patch tested?

Updated existing unit test.

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files).

dariuszzbyrad added some commits Mar 15, 2019

Merge pull request #1 from deeplearning4j/master
Merged changes from original repository
@AlexDBlack
Copy link
Member

left a comment

Ah, good catch. Thanks for the PR!

@AlexDBlack AlexDBlack merged commit 27e69f1 into deeplearning4j:master Mar 19, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@dariuszzbyrad dariuszzbyrad deleted the dariuszzbyrad:fix_7312 branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.