Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[GraphBuilder] Use last added layer/vertex if no inputs specified #7403
What changes were proposed in this pull request?
When building a computation graph with
How was this patch tested?
Removed test that expected exception that now will not be thrown.
So, this is an interesting usability idea.
Now, what might be better is a new method: something like "appendLayer(String, Layer)" Not sure on the best name for that method. But with that, it's explicit - there's no ambiguity for "no input means user forgot" vs. "no input means user wants last layer/vertex to be used".
AlexDBlack left a comment •
This looks good - but I don't like the "treat null as append" behaviour.