New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A listener for visualizing gradients in real time in 3D using JavaFX. #427

Merged
merged 4 commits into from Apr 8, 2017

Conversation

Projects
None yet
3 participants
@DonaldAlan
Contributor

DonaldAlan commented Apr 1, 2017

GradientsListener extends TrainingListener and calls GradientsViewer to do
the visualization. GradientsListener should work with any MultiLayerNetwork.
GradientsListenerExample is a demo.

@DonaldAlan

This comment has been minimized.

Show comment
Hide comment
@DonaldAlan

DonaldAlan Apr 1, 2017

Contributor

This pull request effectively cherry picks just the gradient visualization code from #421 (which also contains MIDI and music code).

Contributor

DonaldAlan commented Apr 1, 2017

This pull request effectively cherry picks just the gradient visualization code from #421 (which also contains MIDI and music code).

@agibsonccc

This comment has been minimized.

Show comment
Hide comment
@agibsonccc

agibsonccc Apr 2, 2017

Member

@huitseeker are javafx apps safe to merge now? I know you did some validation for that.

Member

agibsonccc commented Apr 2, 2017

@huitseeker are javafx apps safe to merge now? I know you did some validation for that.

@agibsonccc agibsonccc requested a review from huitseeker Apr 2, 2017

@DonaldAlan

This comment has been minimized.

Show comment
Hide comment
@DonaldAlan

DonaldAlan Apr 3, 2017

Contributor

http://truthsite.org/music/index.html#visualize for some sample visualizations.

Contributor

DonaldAlan commented Apr 3, 2017

http://truthsite.org/music/index.html#visualize for some sample visualizations.

@huitseeker

This comment has been minimized.

Show comment
Hide comment
@huitseeker

huitseeker Apr 5, 2017

Contributor

@agibsonccc JavaFX works, it's just that you'll get an error message asking for JAVAFX_HOME if/when we can't guess where it is (java < 8 and not from Sun) https://github.com/deeplearning4j/dl4j-examples/blob/master/pom.xml#L148

Contributor

huitseeker commented Apr 5, 2017

@agibsonccc JavaFX works, it's just that you'll get an error message asking for JAVAFX_HOME if/when we can't guess where it is (java < 8 and not from Sun) https://github.com/deeplearning4j/dl4j-examples/blob/master/pom.xml#L148

@huitseeker

I haven't found the time to run this, but the code looks in good shape. The JavaFX dependency is OK IMHO. @DonaldAlan it would help if you added a line to the root Readme.md explaining JavaFX is a dependency, how it's included in a JDK > 1.8, and how you need to set the environment variable JAVAFX_HOME to the location of jfxrt.jar if you have a lesser JDK.

See here for details on how this is handled:
https://github.com/deeplearning4j/dl4j-examples/blob/master/pom.xml#L148

(if you don't fancy doing that, you can open an issue and @mention me)

Thanks for an awesome contribution !

@DonaldAlan

This comment has been minimized.

Show comment
Hide comment
@DonaldAlan

DonaldAlan Apr 7, 2017

Contributor

Darn. Somehow I merged the MIDI & music changes into this branch. That wasn't what I intended to do. I'm working on reverting them. This pull request and the gradientsVisualization branch shouldn't have the MIDI & music code.

Contributor

DonaldAlan commented Apr 7, 2017

Darn. Somehow I merged the MIDI & music changes into this branch. That wasn't what I intended to do. I'm working on reverting them. This pull request and the gradientsVisualization branch shouldn't have the MIDI & music code.

@huitseeker

This comment has been minimized.

Show comment
Hide comment
@huitseeker

huitseeker Apr 7, 2017

Contributor

Your last commit is the only issue. Go to your woking directory, checkout the branch (git checkout gradientVisualisation), rebase interactively on master (git rebase -i origin/master) and then edit the file that so opens, so that only the lines (commits) you want are there.

Contributor

huitseeker commented Apr 7, 2017

Your last commit is the only issue. Go to your woking directory, checkout the branch (git checkout gradientVisualisation), rebase interactively on master (git rebase -i origin/master) and then edit the file that so opens, so that only the lines (commits) you want are there.

DonaldAlan added some commits Apr 1, 2017

A listener for visualizing gradients in real time in 3D using JavaFX.
GradientsListener extends TrainingListener and calls GradientsViewer to do
the visualization. GradientsListener should work with any MultiLayerNetwork.
GradientsListenerExample is a demo.
Prevent the Slider from consuming the key events (LEFT and RIGHT arrow)
which should be consumed by the handleKeyEvent method to navigate in 3D space.
Prevent the Slider from consuming the key events (LEFT and RIGHT arrow)
which should be consumed by the handleKeyEvent method to navigate in 3D space.
@DonaldAlan

This comment has been minimized.

Show comment
Hide comment
@DonaldAlan

DonaldAlan Apr 8, 2017

Contributor

Thank you, François. The branch is now in the desired state.

Contributor

DonaldAlan commented Apr 8, 2017

Thank you, François. The branch is now in the desired state.

@huitseeker huitseeker requested a review from agibsonccc Apr 8, 2017

@agibsonccc agibsonccc merged commit 2a5c0e8 into deeplearning4j:master Apr 8, 2017

@huitseeker

This comment has been minimized.

Show comment
Hide comment
@huitseeker

huitseeker Apr 8, 2017

Contributor

@DonaldAlan thank you for the contribution !

Contributor

huitseeker commented Apr 8, 2017

@DonaldAlan thank you for the contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment