Collection-like Ops are not working. #91

Open
taisukeoe opened this Issue May 27, 2016 · 4 comments

Projects

None yet

4 participants

@taisukeoe
Member

testing with ND4J 0.4-rc3.9 in feature/0.4-rc3.9 branch

[info] NDArrayCollectionAPITest:
[info] CollectionLikeNDArray
[info] - should provides filter API *** FAILED ***
[info]   [[1.00, 2.00, 3.00],
[info]    [4.00, 5.00, 6.00],
[info]    [7.00, 8.00, 9.00]] did not equal [[0.00, 0.00, 0.00],
[info]    [4.00, 5.00, 6.00],
[info]    [7.00, 8.00, 9.00]] (NDArrayCollectionAPITest.scala:17)
[info] - should provides filter bitmask API *** FAILED ***
[info]   [[1.00, 2.00, 3.00],
[info]    [4.00, 5.00, 6.00],
[info]    [7.00, 8.00, 9.00]] did not equal [[0.00, 1.00, 0.00],
[info]    [1.00, 0.00, 1.00],
[info]    [0.00, 1.00, 0.00]] (NDArrayCollectionAPITest.scala:34)
[info] - should provides map API *** FAILED ***
[info]   [[1.00, 2.00, 3.00],
[info]    [4.00, 5.00, 6.00],
[info]    [7.00, 8.00, 9.00]] did not equal [[ 3.00,  5.00,  7.00],
[info]    [ 9.00, 11.00, 13.00],
[info]    [15.00, 17.00, 19.00]] (NDArrayCollectionAPITest.scala:51)
@taisukeoe taisukeoe referenced this issue May 27, 2016
Closed

0.4-rc3.9 release #90

3 of 5 tasks complete
@DaveDeCaprio

I'm seeing this same issue with 5.0.0
println((1 to 9).toNDArray.map(_ + 0.5))
prints
[1.00, 2.00, 3.00, 4.00, 5.00, 6.00, 7.00, 8.00, 9.00]

@agibsonccc
Member

@DaveDeCaprio I don' have developers to put on this right now. You are welcome to send us a pull request.

@saudet
Member
saudet commented Aug 17, 2016

@DaveDeCaprio nd4j doesn't support custom ops written in Java (bytecode) anymore so it's unclear how we should support those operations for now.

@DaveDeCaprio

Thanks, yes I looked at fixing the issue but pretty quickly it became clear this was not a minor bug.

I have a library of primitives for doing very fast off heap computations in Scala. It uses specialization and a few other tricks to allow you to program functionally in Scala, but removing nearly all the overhead. I've used it with (your) JavaCV library. I may try to port it over to work with Nd4s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment