chore: post-#146 cleanup — remove stale warnings + mark probes resolved#154
Merged
Conversation
Issue #146 (multi-BRANCH pause anomaly) closed by v0.3.4's posix_fallocate fix. This PR removes the now-misleading user-facing warnings shipped in 0.3.3 to surface the anomaly, and adds RESOLVED banners to the investigation docs. Code: - forkd-cli `forkd ls`: drop the yellow ⚠ on BRANCHES >=3. The column stays as a diagnostic counter, just no alarm. - forkd-controller branch_sandbox handler: stop generating the "pause_ms typically grows 5×..." warning string for the BRANCH response. SnapshotInfo.warning stays in the schema (Option<String>, skip_serializing_if=None) so future advisories can populate it without an API break. - SandboxInfo.branch_count docstring: rewritten to explain the counter is informational post-v0.3.4, not a slow-regime signal. Docs: - bench/pause-window/PROBE-multi-branch-anomaly.md: STATUS:RESOLVED banner at top, plus a note on the now-superseded round-1 TL;DR. - bench/pause-window/RESULTS-v0.3.md: "What's anomalous (TODO)" rewritten to "What was anomalous (RESOLVED)" with before/after numbers and the fix pointer. - recipes/speculative-agent/README.md: "Rotate the source after N BRANCHes" section retitled to a historical caveat block; rotate- snippet kept for users still on 0.3.3 or older. No API breakage. No behavior change for users on 0.3.4+ except: forkd ls — branch_count no longer rendered yellow above 3 forkd snapshot --from-sandbox --diff — no advisory warning printed (was misleading after fix) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#146 closed by v0.3.4's posix_fallocate fix. This PR removes the now-misleading user-facing warnings (added in 0.3.3 to surface the anomaly) and adds RESOLVED banners to the investigation docs. Pure cleanup, no API breakage.
Changes
Code (small)
Docs
Test plan
🤖 Generated with Claude Code