Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli secrets #154

Merged
merged 6 commits into from Oct 24, 2018
Merged

Fix cli secrets #154

merged 6 commits into from Oct 24, 2018

Conversation

@ramaro
Copy link
Collaborator

ramaro commented Oct 20, 2018

Fixes encoding issues when creating gpg secrets using the cli (#150)
Fixes wrong file argument in cli.py
Breaking change: removes --backend in secrets subcommand. New format for secret token in cli is prefix with backend name (now referred as type_name) e.g. gpg:path/to/secret1
Refactor of cli code into smaller functions easier to test.
Test secret cli write and reveal

ramaro and others added 6 commits Oct 14, 2018
Example steps to reproduce the error before fix:
```
$ echo -n 'bla' | kapitan secrets --write gpg:secrets/common/test_targets/gcp_project_id -f - -t test_terraform_dummy
Traceback (most recent call last):
  File "/Users/rjmco/.pyenv/versions/3.7.0/bin/kapitan", line 11, in <module>
    load_entry_point('kapitan==0.18.2', 'console_scripts', 'kapitan')()
  File "/Users/rjmco/.pyenv/versions/3.7.0/lib/python3.7/site-packages/kapitan/cli.py", line 279, in main
    secret_write(args, ref_controller)
  File "/Users/rjmco/.pyenv/versions/3.7.0/lib/python3.7/site-packages/kapitan/cli.py", line 291, in secret_write
    file_name = args.file_name
AttributeError: 'Namespace' object has no attribute 'file_name'
```

(cherry picked from commit 76699eb)
@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 20, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@rjmco

This comment has been minimized.

Copy link

rjmco commented Oct 20, 2018

I have read and signed the CLA. I confirm the contribution of my commit to this project as per the CLA.

@ramaro ramaro requested review from adrianchifor and gburiola Oct 20, 2018
@gburiola gburiola added cla and removed cla labels Oct 21, 2018
@ramaro ramaro added the cla label Oct 24, 2018
@ramaro ramaro merged commit c20ce73 into deepmind:master Oct 24, 2018
1 of 2 checks passed
1 of 2 checks passed
cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.