Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get Observation/StateInformation for the game of go #37

Closed
Gregory-Eales opened this issue Sep 9, 2019 · 4 comments
Closed

Comments

@Gregory-Eales
Copy link
Contributor

there seems to be no way to access the go board using the python API

@lanctot
Copy link
Collaborator

lanctot commented Sep 9, 2019

You are right, it is simply missing.

Should be quite easy to add go::GoGame::Observation and go::GoGame::ObservationAsNormalizedVector (similar to chess::ChessGame::InformationSetAsNormalizedVector but simpler since there are only two piece types).

Feel free to submit a pull request! Otherwise, we will add it in one of the next updates.

@lanctot
Copy link
Collaborator

lanctot commented Sep 9, 2019

BTW this should be relatively straight-forward, only requiring inspecting the underlying go board object declared here: https://github.com/deepmind/open_spiel/blob/26349aeb2c09cbe8f876678007f9543bf51aa28a/open_spiel/games/go.h#L88

@lanctot
Copy link
Collaborator

lanctot commented Sep 12, 2019

Quick heads up, the information state and observation string functions have been contributed by @Gregory-Eales in PR #40. Thanks!

I will add the Observation as vector shortly.

@lanctot
Copy link
Collaborator

lanctot commented Sep 12, 2019

Re-opening because I'd like to use this issue to test that our automated tools will indeed automatically close the issue when I push to github (and associate the commits properly).

That, and it's not actually in yet! :)

@lanctot lanctot reopened this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants