Skip to content

Conversation

@LanYang430
Copy link
Contributor

modifications:
1.add read_input_info function in dmff.admp.parse.py to deal with info in pdb and xml files (input:pdb,xml output: multipoles/polarizabilities/tholes... and other atomic parameters)
2.use forcefield.xml instead of other xmls, add read_admp_xml in parser in order to read the new form of xml file
3.change line 795 in pme.py and add distribute_matrix in pairwise.py in order to wrap a jit outside my admp_calculator

…d xml (input:pdb,xml output: multipoles/polarizabilities/tholes...)

use forcefield.xml instead of other xmls, add read_admp_xml in parser in order to read the new form of xml file
change line 795 in pme.py and add distribute_matrix in pairwise.py in order to wrap a jit outside my admp_calculator
c0="-1.0614"
dX="0.0" dY="0.0" dZ="-0.023671684"
qXX="0.000150963" qXY="0.0" qYY="0.00008707" qXZ="0.0" qYZ="0.0" qZZ="-0.000238034"
oXXX="0.0" oXXY="0.0" oXYY="0.0" oYYY="0.0" oXXZ="0.0000" oXYZ="0.0" oYYZ="0.00000" oXZZ="0.0" oYZZ="0.0" oZZZ="-0.0000"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the octupole lines to avoid confusion, we do not support octupoles now

c0="0.5307"
dX="0.0" dY="0.0" dZ="0.0"
qXX="0.0" qXY="0.0" qYY="0.0" qXZ="0.0" qYZ="0.0" qZZ="0.0"
oXXX="0.0" oXXY="0.0" oXYY="0.0" oYYY="0.0" oXXZ="0.0" oXYZ="0.0" oYYZ="0.0" oXZZ="0.0" oYZZ="0.0" oZZZ="0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line too

@@ -0,0 +1,485 @@
Traced<ConcreteArray([-0.7778535 0.38892674 0.38892674 -0.7754795 0.38773975 0.38773975], dtype=float32)>with<JVPTrace(level=2/0)> with
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the tmp file, keep it clean

return c0, c6_list

#compute energy with fluctuated leading terms
def admp_calculator(positions, Q_local, axis_type, axis_indices, box, covalent_map, pol, tholes, c_list, q_list, a_list, b_list, pairs, rc):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use standard api to obtain potential functions.

@Ericwang6
Copy link
Member

@humourist Plz remove .forcefield.xml.swp temp files

@KuangYu KuangYu merged commit 00571b4 into deepmodeling:devel Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants