Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: there are cross-interference between test cases in cell_klist_test suite #3889

Closed
9 tasks
kirk0830 opened this issue Apr 2, 2024 · 0 comments
Closed
9 tasks
Assignees
Labels
Questions Raise your quesiton! We will answer it.

Comments

@kirk0830
Copy link
Collaborator

kirk0830 commented Apr 2, 2024

Describe the Testing Issue

see draft PR #3855, the addition of unittests on newly implemented functions should not cause crashes of old unittests, present failure might result from sharing of one K_Vectors instance by all unittest cases.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Understand the testing issue described by the developer.
  • Review the specific test case, expected and actual results, and any error messages.
  • Identify the root cause of the test failure or issue.
  • If a possible solution is suggested, evaluate its feasibility and effectiveness.
  • Implement a fix for the test failure or issue, or create a new test case if needed.
  • Verify that the fix resolves the testing issue and the test case passes.
  • Review and update any relevant documentation, such as test plans or user guides.
  • Ensure the testing issue is resolved and close the ticket.
  • Share any lessons learned or best practices with the team to prevent similar issues in the future.
@kirk0830 kirk0830 added the Tests label Apr 2, 2024
@kirk0830 kirk0830 changed the title Test: there are cross-interference between unittests of cell_klist_test Test: there are cross-interference between test cases in cell_klist_test suite Apr 2, 2024
@mohanchen mohanchen added Questions Raise your quesiton! We will answer it. and removed Tests labels May 5, 2024
@kirk0830 kirk0830 closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Questions Raise your quesiton! We will answer it.
Projects
None yet
2 participants