From be1abfcc8f1290cbca6cd07b23c92317d866f2ec Mon Sep 17 00:00:00 2001 From: Michal Franczel Date: Thu, 6 Nov 2025 17:53:43 +0100 Subject: [PATCH 1/2] chore: bump python version for jupyter-for-local to 3.11 --- .github/workflows/cd.yml | 8 +++++--- bin/test-local | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index bd2920c..6b97c6f 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -20,7 +20,7 @@ env: POETRY_VIRTUALENVS_CREATE: true POETRY_VIRTUALENVS_IN_PROJECT: true POETRY_INSTALLER_PARALLEL: true - JUPYTER_FOR_LOCAL_PYTHON_VERSION: "3.9" + JUPYTER_FOR_LOCAL_PYTHON_VERSION: "3.11" concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -395,13 +395,15 @@ jobs: aws s3 cp "s3://${STAGING_BUCKET}/deepnote-toolkit/${VERSION}/installer.zip" "/tmp/dist${PYTHON_VER}/installer.zip" - name: Build jupyter-for-local docker image + env: + PYTHON_VERSION: ${{ env.JUPYTER_FOR_LOCAL_PYTHON_VERSION }} run: | docker build \ --progress plain \ - --build-arg "FROM_PYTHON_TAG=3.9" \ + --build-arg "FROM_PYTHON_TAG=${PYTHON_VERSION}" \ --build-arg "BUNDLE_PATH=./" \ --tag deepnote/jupyter-for-local:${VERSION} \ - -f dockerfiles/jupyter-for-local/Dockerfile /tmp/dist3.9/ + -f dockerfiles/jupyter-for-local/Dockerfile /tmp/dist${PYTHON_VERSION}/ - name: Push jupyter-for-local image run: | diff --git a/bin/test-local b/bin/test-local index 85b7c39..b22daaf 100755 --- a/bin/test-local +++ b/bin/test-local @@ -15,7 +15,7 @@ cleanup() { trap cleanup EXIT export TOOLKIT_VERSION="local-build" -export PYTHON_VERSION=${PYTHON_VERSION:-"3.9"} +export PYTHON_VERSION=${PYTHON_VERSION:-"3.11"} export COVERAGE_ENABLED=${COVERAGE_ENABLED:-"true"} if [ "${COVERAGE_ENABLED:-true}" = "true" ]; then From 7a475340939d02fcd0ae30abfe8dbcaf6c68195a Mon Sep 17 00:00:00 2001 From: Michal Franczel Date: Thu, 6 Nov 2025 18:09:36 +0100 Subject: [PATCH 2/2] revert: change in test-local --- bin/test-local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/test-local b/bin/test-local index b22daaf..85b7c39 100755 --- a/bin/test-local +++ b/bin/test-local @@ -15,7 +15,7 @@ cleanup() { trap cleanup EXIT export TOOLKIT_VERSION="local-build" -export PYTHON_VERSION=${PYTHON_VERSION:-"3.11"} +export PYTHON_VERSION=${PYTHON_VERSION:-"3.9"} export COVERAGE_ENABLED=${COVERAGE_ENABLED:-"true"} if [ "${COVERAGE_ENABLED:-true}" = "true" ]; then