-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Lower the required VS Code version. #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will make the extension compatible with:
- Cursor 1.7.28 (VSCode 1.99.3) ✅
- Standard VSCode 1.95.0+ ✅
- Other VSCode-based editors with recent versions ✅
The version 1.95.0 is conservative enough to support most modern VSCode-based editors while still being recent enough for current extension features.
📝 WalkthroughWalkthroughThe package.json file has been modified to lower the minimum VS Code engine requirement from version 1.103.0 to version 1.95.0. This expands compatibility by allowing the extension to run on earlier versions of VS Code. The change affects only the Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 539 539
Lines 41267 41267
Branches 5012 5012
=====================================
Hits 30001 30001
Misses 9592 9592
Partials 1674 1674 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build & Package Extension
- GitHub Check: Lint & Format
- GitHub Check: Build & Test
🔇 Additional comments (1)
package.json (1)
26-26: Ignore this review comment; the change is compatible.VS Code 1.95 focused on Copilot, chat, and language model extension APIs—not notebook APIs. The extension's declared
enabledApiProposals(notebookMessaging, notebookMime, notebookExecution, etc.) are stable, pre-existing features unaffected by the version reduction to 1.95.0.Likely an incorrect or invalid review comment.
This will make the extension compatible with:
Version 1.95.0 is conservative enough to support most modern VSCode-based editors while still being recent enough for current extension features.
Summary by CodeRabbit