Skip to content

Conversation

@Artmann
Copy link
Member

@Artmann Artmann commented Oct 29, 2025

This will make the extension compatible with:

  • Cursor 1.7.28 (VSCode 1.99.3) ✅
  • Standard VSCode 1.95.0+ ✅
  • Other VSCode-based editors with recent versions ✅

Version 1.95.0 is conservative enough to support most modern VSCode-based editors while still being recent enough for current extension features.

Summary by CodeRabbit

  • Chores
    • Updated VS Code compatibility requirements to support older versions of the IDE.

 This will make the extension compatible with:
     - Cursor 1.7.28 (VSCode 1.99.3) ✅
     - Standard VSCode 1.95.0+ ✅
     - Other VSCode-based editors with recent versions ✅

The version 1.95.0 is conservative enough to support most modern VSCode-based editors while still being recent enough for current extension features.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

📝 Walkthrough

Walkthrough

The package.json file has been modified to lower the minimum VS Code engine requirement from version 1.103.0 to version 1.95.0. This expands compatibility by allowing the extension to run on earlier versions of VS Code. The change affects only the engines.vscode property.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat: Lower the required VS Code version." directly and accurately reflects the main change in the pull request: updating engines.vscode from ^1.103.0 to ^1.95.0 in package.json. The title is concise, specific, and clearly communicates the primary modification without ambiguity or vagueness.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72%. Comparing base (c9c88ad) to head (a3ad7f5).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #129   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        539     539           
  Lines      41267   41267           
  Branches    5012    5012           
=====================================
  Hits       30001   30001           
  Misses      9592    9592           
  Partials    1674    1674           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9c88ad and a3ad7f5.

📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build & Package Extension
  • GitHub Check: Lint & Format
  • GitHub Check: Build & Test
🔇 Additional comments (1)
package.json (1)

26-26: Ignore this review comment; the change is compatible.

VS Code 1.95 focused on Copilot, chat, and language model extension APIs—not notebook APIs. The extension's declared enabledApiProposals (notebookMessaging, notebookMime, notebookExecution, etc.) are stable, pre-existing features unaffected by the version reduction to 1.95.0.

Likely an incorrect or invalid review comment.

@Artmann Artmann marked this pull request as ready for review October 29, 2025 10:11
@Artmann Artmann requested a review from a team as a code owner October 29, 2025 10:11
@Artmann Artmann enabled auto-merge (squash) October 29, 2025 10:15
@Artmann Artmann merged commit 25d7051 into main Oct 29, 2025
13 checks passed
@Artmann Artmann deleted the chris/cursor-support branch October 29, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants