Skip to content

Conversation

@dinohamzic
Copy link
Member

@dinohamzic dinohamzic commented Oct 29, 2025

Screenshot 2025-10-29 at 13 46 37 Screenshot 2025-10-29 at 14 13 05

Summary by CodeRabbit

  • New Features
    • Added three Deepnote actions: create new project, import notebook, and refresh explorer.
    • Actions appear in the Deepnote explorer title menu and are grouped for easy access.
    • Added a "Deepnote" submenu in the explorer context menu; its items (new project, import notebook) appear when the workspace is trusted.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

📝 Walkthrough

Walkthrough

Adds menu contributions and a submenu to package.json for the Deepnote extension: three view/title entries (deepnote.newProject, deepnote.importNotebook, deepnote.refreshExplorer) shown when view == deepnoteExplorer; a new submenu deepnote.explorer.context labeled "Deepnote"; and an explorer/context entry that references that submenu (shown when isWorkspaceTrusted). Only menu/submenu registrations are added; no runtime behavior or command implementations are modified.

Sequence Diagram(s)

sequenceDiagram
    participant VSCode
    participant View as Deepnote Explorer View
    participant MenuSys as Menu Registry
    participant Submenu as "deepnote.explorer.context"
    participant Cmd1 as deepnote.newProject
    participant Cmd2 as deepnote.importNotebook
    participant Cmd3 as deepnote.refreshExplorer

    Note over VSCode,MenuSys: package.json contributes.menus & submenus loaded
    VSCode->>MenuSys: register view/title when view==deepnoteExplorer
    MenuSys-->>View: show [Cmd1, Cmd2, Cmd3] in view toolbar (groups navigation@1/2/3)
    VSCode->>MenuSys: register explorer/context submenu when isWorkspaceTrusted
    MenuSys-->>Submenu: declare submenu (label: "Deepnote")
    MenuSys-->>VSCode: expose submenu under explorer/context (group navigation@10)
    Note over View,VSCode: User triggers a command
    View->>Cmd1: invoke deepnote.newProject
    View->>Cmd2: invoke deepnote.importNotebook
    View->>Cmd3: invoke deepnote.refreshExplorer
Loading

Possibly related PRs

Suggested reviewers

  • saltenasl
  • jamesbhobbs

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "feat: Add Deepnote commands to view title bar and explorer context menu" directly and accurately reflects the changeset's core purpose. The raw summary confirms that three commands are added to the view title bar (view/title entries) and additional commands are exposed via a new submenu in the explorer context menu. The title is specific and concise—it clearly identifies what was added (Deepnote commands) and where (view title bar and explorer context), allowing a teammate to quickly understand the main change without ambiguity.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72%. Comparing base (c85f4fb) to head (883c72c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #131   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        539     539           
  Lines      41267   41267           
  Branches    5012    5012           
=====================================
  Hits       30001   30001           
  Misses      9592    9592           
  Partials    1674    1674           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 29, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 29, 2025
@dinohamzic dinohamzic self-assigned this Oct 29, 2025
@dinohamzic dinohamzic marked this pull request as ready for review October 29, 2025 13:27
@dinohamzic dinohamzic requested a review from a team as a code owner October 29, 2025 13:27
},
{
"id": "deepnote.explorer.context",
"label": "Deepnote"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use a translation string like: %deepnote.title%

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean as a single source of truth for our company name?

If yes, makes sense to me, but I'm not sure if it's a good pattern to store something that won't ever be translated in a translation file. Your call, let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good point.

@dinohamzic dinohamzic merged commit e683e42 into main Oct 29, 2025
12 of 13 checks passed
@dinohamzic dinohamzic deleted the dinohamzic/deepnote-commands-in-ui branch October 29, 2025 14:02
dinohamzic added a commit that referenced this pull request Oct 30, 2025
…nu (#131)

* feat: Add Deepnote commands to view title bar and explorer context menu

* feat: tweak position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants