-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add Deepnote commands to view title bar and explorer context menu #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds menu contributions and a submenu to package.json for the Deepnote extension: three view/title entries (deepnote.newProject, deepnote.importNotebook, deepnote.refreshExplorer) shown when Sequence Diagram(s)sequenceDiagram
participant VSCode
participant View as Deepnote Explorer View
participant MenuSys as Menu Registry
participant Submenu as "deepnote.explorer.context"
participant Cmd1 as deepnote.newProject
participant Cmd2 as deepnote.importNotebook
participant Cmd3 as deepnote.refreshExplorer
Note over VSCode,MenuSys: package.json contributes.menus & submenus loaded
VSCode->>MenuSys: register view/title when view==deepnoteExplorer
MenuSys-->>View: show [Cmd1, Cmd2, Cmd3] in view toolbar (groups navigation@1/2/3)
VSCode->>MenuSys: register explorer/context submenu when isWorkspaceTrusted
MenuSys-->>Submenu: declare submenu (label: "Deepnote")
MenuSys-->>VSCode: expose submenu under explorer/context (group navigation@10)
Note over View,VSCode: User triggers a command
View->>Cmd1: invoke deepnote.newProject
View->>Cmd2: invoke deepnote.importNotebook
View->>Cmd3: invoke deepnote.refreshExplorer
Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 539 539
Lines 41267 41267
Branches 5012 5012
=====================================
Hits 30001 30001
Misses 9592 9592
Partials 1674 1674 🚀 New features to boost your workflow:
|
ae3a95b to
d72d821
Compare
d72d821 to
5ff2133
Compare
| }, | ||
| { | ||
| "id": "deepnote.explorer.context", | ||
| "label": "Deepnote" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use a translation string like: %deepnote.title%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean as a single source of truth for our company name?
If yes, makes sense to me, but I'm not sure if it's a good pattern to store something that won't ever be translated in a translation file. Your call, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a good point.
…nu (#131) * feat: Add Deepnote commands to view title bar and explorer context menu * feat: tweak position
Summary by CodeRabbit