From 5bd05bcf658c4d3b765c49939bb8730a83bbc8ae Mon Sep 17 00:00:00 2001 From: Lukas Saltenas Date: Sat, 1 Nov 2025 16:08:42 +0200 Subject: [PATCH 1/3] fix: NaN rows in dataframe output renderer --- .../webview-side/dataframe-renderer/DataframeRenderer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx index 4dd85fa068..74d9ccd537 100644 --- a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx +++ b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx @@ -75,7 +75,7 @@ export const DataframeRenderer = memo(function DataframeRenderer({ const selectId = useMemo(() => generateUuid(), []); const filteredColumns = data.columns.filter((column) => !column.name.startsWith('_deepnote_')); - const numberOfRows = Math.min(data.row_count, data.preview_row_count); + const numberOfRows = data.preview_row_count ?? data.row_count; const numberOfColumns = filteredColumns.length; const totalPages = Math.ceil(data.row_count / pageSize); From 9659fac27a8d590bc4f8ee031d3ea8de953cd73d Mon Sep 17 00:00:00 2001 From: Lukas Saltenas Date: Sat, 1 Nov 2025 16:31:30 +0200 Subject: [PATCH 2/3] fix: types and nan --- .../webview-side/dataframe-renderer/DataframeRenderer.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx index 74d9ccd537..ba61e5ca2c 100644 --- a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx +++ b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx @@ -38,7 +38,7 @@ interface DataframeRendererProps { name: string; stats: ColumnStats; }[]; - preview_row_count: number; + preview_row_count?: number; row_count: number; rows: { _deepnote_index_column: number; @@ -75,7 +75,8 @@ export const DataframeRenderer = memo(function DataframeRenderer({ const selectId = useMemo(() => generateUuid(), []); const filteredColumns = data.columns.filter((column) => !column.name.startsWith('_deepnote_')); - const numberOfRows = data.preview_row_count ?? data.row_count; + const numberOfRows = + !data.preview_row_count || Number.isNaN(data.preview_row_count) ? data.row_count : data.preview_row_count; const numberOfColumns = filteredColumns.length; const totalPages = Math.ceil(data.row_count / pageSize); From a08be2ea14dce9a4a57331974484489bdae7b6d4 Mon Sep 17 00:00:00 2001 From: Lukas Saltenas Date: Sat, 1 Nov 2025 16:48:44 +0200 Subject: [PATCH 3/3] fix: coderabbits comments --- src/webviews/extension-side/dataframe/dataframeController.ts | 2 +- .../webview-side/dataframe-renderer/DataframeRenderer.tsx | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/webviews/extension-side/dataframe/dataframeController.ts b/src/webviews/extension-side/dataframe/dataframeController.ts index cfbef322ca..3c5093afb8 100644 --- a/src/webviews/extension-side/dataframe/dataframeController.ts +++ b/src/webviews/extension-side/dataframe/dataframeController.ts @@ -47,7 +47,7 @@ interface DataFrameObject { dtype: string; name: string; }[]; - preview_row_count: number; + preview_row_count?: number; row_count: number; rows: Record[]; type: string; diff --git a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx index ba61e5ca2c..20dc425ed6 100644 --- a/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx +++ b/src/webviews/webview-side/dataframe-renderer/DataframeRenderer.tsx @@ -75,8 +75,7 @@ export const DataframeRenderer = memo(function DataframeRenderer({ const selectId = useMemo(() => generateUuid(), []); const filteredColumns = data.columns.filter((column) => !column.name.startsWith('_deepnote_')); - const numberOfRows = - !data.preview_row_count || Number.isNaN(data.preview_row_count) ? data.row_count : data.preview_row_count; + const numberOfRows = Number.isFinite(data.preview_row_count) ? data.preview_row_count : data.row_count; const numberOfColumns = filteredColumns.length; const totalPages = Math.ceil(data.row_count / pageSize);