Skip to content

Conversation

@saltenasl
Copy link
Member

@saltenasl saltenasl commented Nov 5, 2025

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Output logging no longer automatically displays on startup, providing a cleaner initial experience while maintaining all logging functionality.

@saltenasl saltenasl requested a review from a team as a code owner November 5, 2025 07:50
@saltenasl saltenasl requested a review from tkislan November 5, 2025 07:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

📝 Walkthrough

Walkthrough

The change removes the automatic invocation of VSCode's OutputChannel display during logger initialization. The standardOutputChannel continues to be created and configured with an OutputChannelLogger, but the default show() call is eliminated. This preserves all logging functionality while deferring the OutputChannel's visibility to later user interaction or explicit calls.

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately describes the main change: removing automatic VSCode OutputChannel display on initialization.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f1e302 and 8e34abb.

📒 Files selected for processing (1)
  • src/platform/logging/index.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/platform/logging/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (8f1e302) to head (8e34abb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #186   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        575     575           
  Lines      46924   46923    -1     
  Branches    5521    5521           
=====================================
  Hits       34490   34490           
+ Misses     10612   10611    -1     
  Partials    1822    1822           
Files with missing lines Coverage Δ
src/platform/logging/index.ts 58% <ø> (+<1%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl merged commit 55577b5 into main Nov 5, 2025
13 checks passed
@saltenasl saltenasl deleted the ls/do-not-open-vscode-outputs branch November 5, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants