-
Notifications
You must be signed in to change notification settings - Fork 4
ci: add typecheck to CI workflow #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add typecheck to CI workflow #36
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughAdds a new GitHub Actions CI job named Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Build as Build & Test Job
participant TypeCheck as TypeCheck Job
participant Runner as ubuntu-latest Runner
participant Node as Node / deps
Note over GH: Workflow start triggers multiple jobs in parallel
GH->>Build: Start Build & Test
GH->>TypeCheck: Start TypeCheck
Build->>Runner: Checkout, setup, run tests
TypeCheck->>Runner: Checkout
TypeCheck->>Node: Setup Node / Install deps
TypeCheck->>Node: Run "npm run typecheck"
Note right of TypeCheck: New parallel job added
Runner-->>Build: Build result
Runner-->>TypeCheck: Typecheck result
Build-->>GH: Report status
TypeCheck-->>GH: Report status
Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
fa9c3a6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 512 512
Lines 37506 37506
Branches 4811 4811
=====================================
Hits 26473 26473
Misses 9441 9441
Partials 1592 1592 🚀 New features to boost your workflow:
|
| - name: Check Prettier formatting | ||
| run: npm run format | ||
|
|
||
| typecheck: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are deliberately separated to maintain consistency in status check between repos so far as is reasonable.
i.e. it could be one line above but isn't so there's a clear CI/Typecheck status check on our PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
Summary
Adds TypeScript type checking (
npm run typecheck) to the CI workflow to close a gap in code quality checks.Link to Devin run: https://app.devin.ai/sessions/9e3cf61ddf4a46e69f865e76354192dc
Requested by: @jamesbhobbs
Summary by CodeRabbit