Skip to content

Conversation

@jamesbhobbs
Copy link
Contributor

@jamesbhobbs jamesbhobbs commented Oct 10, 2025

Summary

Adds TypeScript type checking (npm run typecheck) to the CI workflow to close a gap in code quality checks.


Link to Devin run: https://app.devin.ai/sessions/9e3cf61ddf4a46e69f865e76354192dc
Requested by: @jamesbhobbs

Summary by CodeRabbit

  • Chores
    • Added automated type checking in the continuous integration pipeline to detect type issues earlier.
    • This improves code quality and reduces the risk of regressions reaching production by providing faster feedback during development.
    • No user-facing changes.

@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Adds a new GitHub Actions CI job named TypeCheck (runs on ubuntu-latest, 15-minute timeout) that checks out the repo, sets up Node.js, installs dependencies, and runs TypeScript type checking via npm run typecheck. This job runs in parallel to existing CI jobs. No changes to exported/public entities.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant GH as GitHub Actions
  participant Build as Build & Test Job
  participant TypeCheck as TypeCheck Job
  participant Runner as ubuntu-latest Runner
  participant Node as Node / deps
  Note over GH: Workflow start triggers multiple jobs in parallel
  GH->>Build: Start Build & Test
  GH->>TypeCheck: Start TypeCheck
  Build->>Runner: Checkout, setup, run tests
  TypeCheck->>Runner: Checkout
  TypeCheck->>Node: Setup Node / Install deps
  TypeCheck->>Node: Run "npm run typecheck"
  Note right of TypeCheck: New parallel job added
  Runner-->>Build: Build result
  Runner-->>TypeCheck: Typecheck result
  Build-->>GH: Report status
  TypeCheck-->>GH: Report status
Loading

Possibly related PRs

Suggested reviewers

  • Artmann
  • andyjakubowski
  • saltenasl

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and clearly summarizes the main change—adding the TypeScript typecheck step to the CI workflow—using a conventional commit style short sentence that directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70%. Comparing base (0b41226) to head (9560354).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #36   +/-   ##
=====================================
  Coverage     70%     70%           
=====================================
  Files        512     512           
  Lines      37506   37506           
  Branches    4811    4811           
=====================================
  Hits       26473   26473           
  Misses      9441    9441           
  Partials    1592    1592           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesbhobbs jamesbhobbs marked this pull request as ready for review October 10, 2025 12:34
- name: Check Prettier formatting
run: npm run format

typecheck:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are deliberately separated to maintain consistency in status check between repos so far as is reasonable.

i.e. it could be one line above but isn't so there's a clear CI/Typecheck status check on our PRs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe7cbe and 9560354.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe7cbe and 9560354.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants