Skip to content

ci: add typecheck to CI workflow #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

ci: add typecheck to CI workflow #36

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fe7cbe
ci: add typecheck to CI workflow
devin-ai-integration[bot] Oct 10, 2025
fa9c3a6
ci: move typecheck to separate job for separate check status
devin-ai-integration[bot] Oct 10, 2025
9560354
Merge branch 'main' into devin/1760099059-add-comprehensive-ci-checks
jamesbhobbs Oct 10, 2025
bd5bf8b
Merge branch 'main' into devin/1760099059-add-comprehensive-ci-checks
jamesbhobbs Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,30 @@ jobs:
- name: Check Prettier formatting
run: npm run format

typecheck:
Copy link
Contributor Author

@jamesbhobbs jamesbhobbs Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are deliberately separated to maintain consistency in status check between repos so far as is reasonable.

i.e. it could be one line above but isn't so there's a clear CI/Typecheck status check on our PRs

name: TypeCheck
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

- name: Install dependencies
run: npm ci --prefer-offline --no-audit
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run TypeScript type checking
run: npm run typecheck

qlty:
name: Qlty Check
runs-on: ubuntu-latest
Expand Down
Loading