-
Notifications
You must be signed in to change notification settings - Fork 4
chore: sync strict TypeScript compiler flags from deepnote/deepnote #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync strict TypeScript compiler flags from deepnote/deepnote #39
Conversation
- Add forceConsistentCasingInFileNames to ensure import paths match exact file casing - Add skipLibCheck to skip type checking of declaration files for faster builds These flags align with the strict configuration used in deepnote/deepnote and improve type safety and consistency across the codebase.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughUpdated tsconfig.base.json by adding two compilerOptions: forceConsistentCasingInFileNames: true and skipLibCheck: true. These options enforce consistent file name casing in imports and skip type checking of declaration (*.d.ts) files. No runtime code paths or application logic were changed. Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 512 512
Lines 37506 37506
Branches 4811 4811
=====================================
Hits 26473 26473
Misses 9441 9441
Partials 1592 1592 🚀 New features to boost your workflow:
|
Summary
Adds two strict TypeScript compiler flags to
tsconfig.base.jsonto align vscode-deepnote's configuration with deepnote/deepnote:forceConsistentCasingInFileNames: Ensures import paths match exact file casing (helps catch cross-platform issues)skipLibCheck: Skips type checking of declaration files for faster buildsThis is part of a broader effort to synchronize tooling configurations across deepnote/deepnote, jupyterlab-deepnote, and vscode-deepnote repositories, focusing on consistent code quality tooling for src/ directories.
Changes Made
forceConsistentCasingInFileNames: trueto strictness section intsconfig.base.jsonskipLibCheck: trueto strictness section intsconfig.base.jsonTesting
✅ Local verification completed successfully:
npm run compile- TypeScript compilation passesnpm run lint- ESLint passesnpm run format- Prettier formatting check passesnpm run typecheck- TypeScript type checking passesnpm test- All 1329 tests passHuman Review Checklist
forceConsistentCasingInFileNamesskipLibCheckmight mask important dependency type issuesLink to Devin run: https://app.devin.ai/sessions/145f89c8cbc942d2970c5bc43a90149c
Requested by: @jamesbhobbs
Summary by CodeRabbit