-
Notifications
You must be signed in to change notification settings - Fork 4
fix(codecov-for-dependabot): use oidc when uploading test results to codecov #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe CI workflow (.github/workflows/ci.yml) updates the Build & Test job permissions to include id-token: write and contents: read. Codecov integrations are switched to OpenID Connect by setting use_oidc: true for both coverage (coverage/lcov.info) and test results uploads. Token-based authentication for Codecov is removed. The test results artifact path is changed from test-report.xml to test-results.xml. Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions (Build & Test)
participant OIDC as GitHub OIDC Provider
participant CC as Codecov
Dev->>GH: Push/PR triggers workflow
note over GH: Permissions: id-token: write<br/>contents: read
GH->>OIDC: Request OIDC ID token
OIDC-->>GH: OIDC token (JWT)
GH->>GH: Run tests, generate coverage (coverage/lcov.info)<br/>and test results (test-results.xml)
GH->>CC: Upload coverage with use_oidc: true
CC-->>GH: Acknowledge coverage upload
GH->>CC: Upload test results with use_oidc: true
CC-->>GH: Acknowledge test results upload
note over GH,CC: No explicit Codecov token used
Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 512 512
Lines 37506 37506
Branches 4811 4811
=====================================
Hits 26473 26473
Misses 9441 9441
Partials 1592 1592 🚀 New features to boost your workflow:
|
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: test-report.xml | ||
| use_oidc: true | ||
| files: test-results.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can omit the line entirely and it'd be fine.
Fixes failing
cibuildjobUpload test results to CodecovandUpload coverage to Codecov.Summary by CodeRabbit
Chores
Tests