Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telegram Bot #58

Merged
merged 6 commits into from Mar 23, 2020
Merged

Add Telegram Bot #58

merged 6 commits into from Mar 23, 2020

Conversation

@theapache64
Copy link
Collaborator

theapache64 commented Mar 22, 2020

  • Fix README typos.
@tholor

This comment has been minimized.

Copy link
Contributor

tholor commented Mar 23, 2020

Thanks again for creating this PR. Great work!

Two comments:

  • Right now the answer displayed by the bot doesn't contain the "matched question". However, it might be helpful for the users to see that in order to judge if the answer is really relevant to their question. You find it in the response JSON in the field "question".
  • We now also have the option for user feedback (see API endpoint). So people can rate if the given answer was helpful or not and we will use the data to improve the NLP model. This could be also an helpful addition to the telegram bot.

Would be great to hear your thoughts on that and maybe address them in a separate PR.

@tholor
tholor approved these changes Mar 23, 2020
@tholor tholor merged commit 97cf029 into deepset-ai:master Mar 23, 2020
@theapache64

This comment has been minimized.

Copy link
Collaborator Author

theapache64 commented Mar 23, 2020

Right now the answer displayed by the bot doesn't contain the "matched question". However, it might be helpful for the users to see that in order to...

Okay. That'll be good. I can include the matched question.

We now also have the option for user feedback (see API endpoint). So people can rate if the given answer was helpful or ...

Definitely. I'll include that as well.

I'll start working on these requirements and will let you know once it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.