Skip to content

docs: Update Agent docs to reflect new features and explain different common patterns#11254

Merged
sjrl merged 8 commits into
mainfrom
agent-docs
May 5, 2026
Merged

docs: Update Agent docs to reflect new features and explain different common patterns#11254
sjrl merged 8 commits into
mainfrom
agent-docs

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented May 5, 2026

Related Issues

Proposed Changes:

  • Update Agent docs to include information about new features that have been added
  • Update examples to use recommended patterns especially around designing tools
  • Restructure the docs to make them easier to understand and navigate
  • Made the Multi Agent Systems section to better highlight multi agents in Haystack and when they should be used (e.g. context engineering)

How did you test it?

Ran the code blocks locally.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment May 5, 2026 9:51am

Request Review

@sjrl sjrl self-assigned this May 5, 2026
@sjrl sjrl marked this pull request as ready for review May 5, 2026 08:53
@sjrl sjrl requested a review from a team as a code owner May 5, 2026 08:53
@sjrl sjrl requested review from davidsbatista and julian-risch and removed request for a team May 5, 2026 08:53
@claude
Copy link
Copy Markdown

claude Bot commented May 5, 2026

Code review

Bug: Invalid model name gpt-5.4-nano

gpt-5.4-nano is not a real OpenAI model and will cause a model_not_found error at runtime for anyone copy-pasting the examples in this PR.

The codebase's own authoritative SUPPORTED_MODELS list in openai.py confirms:

  • gpt-5-nano ✅ (real model, used throughout the test suite)
  • gpt-5.4 ✅ (real model in SUPPORTED_MODELS)
  • gpt-5.4-nano ❌ (does not exist — the 5.4 decimal-versioned family has -pro/-chat/-codex variants, not -nano)

The intended replacement for the previous gpt-4o-mini examples is almost certainly gpt-5-nano.

Affected locations (both docs-website/docs/pipeline-components/agents-1/agent.mdx and docs-website/versioned_docs/version-2.28/pipeline-components/agents-1/agent.mdx):

  • Line 94: calculator example
  • Line 148: database pipeline example
  • Line 222: YAML example
  • Line 325: streaming example
  • Lines 391 and 409: multi-agent example

Suggested fix: replace all occurrences of gpt-5.4-nano with gpt-5-nano.

@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented May 5, 2026

Code review

Bug: Invalid model name gpt-5.4-nano

gpt-5.4-nano is not a real OpenAI model and will cause a model_not_found error at runtime for anyone copy-pasting the examples in this PR.

The codebase's own authoritative SUPPORTED_MODELS list in openai.py confirms:

  • gpt-5-nano ✅ (real model, used throughout the test suite)
  • gpt-5.4 ✅ (real model in SUPPORTED_MODELS)
  • gpt-5.4-nano ❌ (does not exist — the 5.4 decimal-versioned family has -pro/-chat/-codex variants, not -nano)

The intended replacement for the previous gpt-4o-mini examples is almost certainly gpt-5-nano.

Affected locations (both docs-website/docs/pipeline-components/agents-1/agent.mdx and docs-website/versioned_docs/version-2.28/pipeline-components/agents-1/agent.mdx):

  • Line 94: calculator example
  • Line 148: database pipeline example
  • Line 222: YAML example
  • Line 325: streaming example
  • Lines 391 and 409: multi-agent example

Suggested fix: replace all occurrences of gpt-5.4-nano with gpt-5-nano.

How do we update Claude? XD

Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit pick otherwise looks good to me. I'll approve right after applying my suggestions

Comment thread docs-website/docs/pipeline-components/agents-1/agent.mdx Outdated
Comment thread docs-website/versioned_docs/version-2.28/pipeline-components/agents-1/agent.mdx Outdated
Co-authored-by: Julian Risch <julianrisch@gmx.de>
@sjrl sjrl merged commit f3841d2 into main May 5, 2026
20 checks passed
@sjrl sjrl deleted the agent-docs branch May 5, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants