From bf9541eba17e2f868b2b3856d435966b8f52daa0 Mon Sep 17 00:00:00 2001 From: Sebastian Husch Lee Date: Fri, 15 May 2026 10:19:10 +0200 Subject: [PATCH] Add missing init param to to_dict in hf doc embedder --- .../embedders/hugging_face_api_document_embedder.py | 1 + ...-document-embedder-concurrency-limit-294a8c69eb3792c4.yaml | 4 ++++ .../embedders/test_hugging_face_api_document_embedder.py | 4 ++++ 3 files changed, 9 insertions(+) create mode 100644 releasenotes/notes/serialize-hf-api-document-embedder-concurrency-limit-294a8c69eb3792c4.yaml diff --git a/haystack/components/embedders/hugging_face_api_document_embedder.py b/haystack/components/embedders/hugging_face_api_document_embedder.py index e35e910db1..0b2951f8ed 100644 --- a/haystack/components/embedders/hugging_face_api_document_embedder.py +++ b/haystack/components/embedders/hugging_face_api_document_embedder.py @@ -211,6 +211,7 @@ def to_dict(self) -> dict[str, Any]: progress_bar=self.progress_bar, meta_fields_to_embed=self.meta_fields_to_embed, embedding_separator=self.embedding_separator, + concurrency_limit=self.concurrency_limit, ) @classmethod diff --git a/releasenotes/notes/serialize-hf-api-document-embedder-concurrency-limit-294a8c69eb3792c4.yaml b/releasenotes/notes/serialize-hf-api-document-embedder-concurrency-limit-294a8c69eb3792c4.yaml new file mode 100644 index 0000000000..ccd09cb326 --- /dev/null +++ b/releasenotes/notes/serialize-hf-api-document-embedder-concurrency-limit-294a8c69eb3792c4.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - | + Fixed ``HuggingFaceAPIDocumentEmbedder`` serialization to preserve the configured ``concurrency_limit``. diff --git a/test/components/embedders/test_hugging_face_api_document_embedder.py b/test/components/embedders/test_hugging_face_api_document_embedder.py index 7d62f5925b..ea9794b3a3 100644 --- a/test/components/embedders/test_hugging_face_api_document_embedder.py +++ b/test/components/embedders/test_hugging_face_api_document_embedder.py @@ -107,6 +107,7 @@ def test_to_dict(self, mock_check_valid_model): progress_bar=False, meta_fields_to_embed=["meta_field"], embedding_separator=" ", + concurrency_limit=7, ) data = embedder.to_dict() @@ -125,6 +126,7 @@ def test_to_dict(self, mock_check_valid_model): "progress_bar": False, "meta_fields_to_embed": ["meta_field"], "embedding_separator": " ", + "concurrency_limit": 7, }, } @@ -143,6 +145,7 @@ def test_from_dict(self, mock_check_valid_model): "progress_bar": False, "meta_fields_to_embed": ["meta_field"], "embedding_separator": " ", + "concurrency_limit": 7, }, } @@ -158,6 +161,7 @@ def test_from_dict(self, mock_check_valid_model): assert not embedder.progress_bar assert embedder.meta_fields_to_embed == ["meta_field"] assert embedder.embedding_separator == " " + assert embedder.concurrency_limit == 7 def test_prepare_texts_to_embed_w_metadata(self): documents = [