Skip to content

docs: add test directory convention to AGENTS.md#7993

Closed
delock wants to merge 1 commit into
masterfrom
gma/update_agents_md
Closed

docs: add test directory convention to AGENTS.md#7993
delock wants to merge 1 commit into
masterfrom
gma/update_agents_md

Conversation

@delock
Copy link
Copy Markdown
Collaborator

@delock delock commented May 6, 2026

This PR is to tell agents that new tests needs to go to tests/unit/v1 instead of tests/unit/ to enter CI test.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6377406849

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread AGENTS.md Outdated
Signed-off-by: Guokai Ma <guokai.ma@intel.com>
@delock delock force-pushed the gma/update_agents_md branch from 6377406 to 809c56c Compare May 6, 2026 07:00
@tohtana
Copy link
Copy Markdown
Collaborator

tohtana commented May 18, 2026

Hi @delock,
This update looks good, but isn't "New tests must go under tests/unit/v1/" too strict?
We have the full nightly test. We sometimes miss issues that only the full test capure when we merge a PR, but it is still good to add some non-critical tests there rather than tests/unit/v1/.

The other direction is we can actually add everything to tests/unit/v1/ and occasionally move them to the nightly test.

@delock
Copy link
Copy Markdown
Collaborator Author

delock commented May 22, 2026

Hi @delock, This update looks good, but isn't "New tests must go under tests/unit/v1/" too strict? We have the full nightly test. We sometimes miss issues that only the full test capure when we merge a PR, but it is still good to add some non-critical tests there rather than tests/unit/v1/.

The other direction is we can actually add everything to tests/unit/v1/ and occasionally move them to the nightly test.

Hi @tohtana thanks for the comments. I agree that we'd expect an agent to figure this out by making a more rational decison based on the situation, rather than following a simple rule.

Let me close this PR and go back if we have better hints.

@delock delock closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants