This repository has been archived by the owner on Jul 8, 2023. It is now read-only.
Implemented goBack Functionality #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tharun208
commented
Dec 16, 2018
tharun208
commented
- Added GoBack Functionality
- Added tests for GoBack Function
deepsweet
suggested changes
Dec 17, 2018
src/api/Page.ts
Outdated
| @@ -302,6 +302,9 @@ class Page extends EventEmitter { | |||
| }) | |||
| `) as TResult | |||
| } | |||
| async goBack(): Promise<string> { | |||
There was a problem hiding this comment.
I believe that it doesn't return anything, so it should be Promise<void>
src/api/Page.ts
Outdated
| @@ -302,6 +302,9 @@ class Page extends EventEmitter { | |||
| }) | |||
| `) as TResult | |||
| } | |||
| async goBack(): Promise<string> { | |||
| return this._send('WebDriver:Back', {} ) as Promise<string> | |||
There was a problem hiding this comment.
which also means no return here, just await
|
Fixed the changes ! |
|
thanks! do you mind fixing lint issues? https://travis-ci.org/deepsweet/foxr/jobs/469398109 you can check it locally by running |
deepsweet
approved these changes
Dec 20, 2018
|
Hi, |
Codecov Report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.