Skip to content

Mark Deepwell
deepwell

  • Joined on Sep 22, 2010

Organizations

@stage3systems
May 27, 2016
@deepwell
  • ec5bab2
    SED-1464 remove unneeded test
May 17, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

I have found 2 more cases that this code currently fails, I have added them as unit tests in ea74e10 in the branch.

May 17, 2016
@deepwell
May 17, 2016
@deepwell
  • 913bf44
    SED-1464 Trim extra whitespace in class names
May 17, 2016
@deepwell
May 17, 2016
@deepwell
  • 1c3caa7
    Trim extra whitespace in class names
May 14, 2016
deepwell commented on issue felixge/node-mysql#1415
@deepwell

That's what I thought when looking at the code. I haven't been able to reproduce it and don't have any more debug info to give you. I simply saw it…

May 13, 2016
@deepwell
RangeError: Invalid array buffer length
May 11, 2016
@deepwell
  • fc3b3e6
    Trim extra whitespace in class names
May 5, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

Hi Tajinder, can you please rebase this and the sedna branch on top of master? There have been some updates since this was started.

deepwell deleted branch update-deps at stage3systems/node-html5-purifier
May 5, 2016
deepwell deleted branch features/fix-style-parser at stage3systems/node-html5-purifier
May 5, 2016
May 5, 2016
@deepwell
May 5, 2016
@deepwell
Remove invalid CSS on parsing errors
1 commit with 25 additions and 0 deletions
May 5, 2016
@deepwell
Remove invalid CSS on parsing errors
1 commit with 25 additions and 0 deletions
May 5, 2016
Apr 30, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

Can you explain what isReverted is for and why we need to pass this back?

Apr 30, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

This should be done in the namespacer.

Apr 28, 2016
Apr 21, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

This could cause it to crash as well if the postfix is part of a class name that's not at the beginning.

Apr 21, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

I see hasClass is not used anywhere. Ideally if there are no class names left (they all have been removed). We should not add class="" to the html …

Apr 21, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

I managed to break it by making this while loop run forever. All I did was added the prefix ugc to part of the html body that's not in a class name.

Apr 21, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

I didn't see any unit tests for this function, can you add one to ensure this function works? While the other tests you have ensure smaller parts o…

Apr 21, 2016
deepwell commented on pull request stage3systems/node-html5-purifier#6
@deepwell

We're not really reverting the purify process here, instead we're reverting the namespaced classes and styles. Can you rename this to revertNamespace?

Apr 1, 2016
@deepwell
Add caja fork for cid images
deepwell deleted branch add-caja-cid-uri at stage3systems/node-html5-purifier
Apr 1, 2016
Something went wrong with that request. Please try again.