Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update quicktype-core version #264

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

schaeferka
Copy link
Contributor

Need to update quicktype-core version to latest release. Current version results in this error:

Link

[Release: node_modules/quicktype-core/dist/input/JSONSchemaInput.d.ts#L1](https://github.com/defenseunicorns/kubernetes-fluent-client/commit/793ca7b03bc81756541cc513871728a24f1d4a9b#annotation_21521061930)
Could not find a declaration file for module 'urijs'. '/home/runner/work/kubernetes-fluent-client/kubernetes-fluent-client/node_modules/urijs/src/URI.js' implicitly has an 'any' type.

@schaeferka schaeferka linked an issue May 29, 2024 that may be closed by this pull request
@schaeferka schaeferka self-assigned this May 29, 2024
@schaeferka schaeferka marked this pull request as draft May 29, 2024 16:09
@schaeferka
Copy link
Contributor Author

schaeferka commented May 29, 2024

Updating quicktype-core to v23.0.168 from 23.0.158 appears to have resolved the issue. But we are getting dependency review errors:

package-lock.json » jose@4.15.4 – jose vulnerable to resource exhaustion via specifically crafted JWE with compressed plaintext (moderate severity)
    ↪ https://github.com/advisories/GHSA-hhhv-q5[7](https://github.com/defenseunicorns/kubernetes-fluent-client/actions/runs/9289590330/job/25563960006?pr=264#step:3:8)g-[8](https://github.com/defenseunicorns/kubernetes-fluent-client/actions/runs/9289590330/job/25563960006?pr=264#step:3:9)82q

  package-lock.json » tar@6.2.0 – Denial of service while parsing a tar file due to lack of folders count validation (moderate severity)
    ↪ https://github.com/advisories/GHSA-f5x3-32g6-xq36

  Error: Dependency review detected vulnerable packages.

@schaeferka schaeferka marked this pull request as ready for review May 29, 2024 17:01
@cmwylie19 cmwylie19 changed the title chore: update quicktype-core version fix: update quicktype-core version May 29, 2024
@cmwylie19 cmwylie19 changed the title fix: update quicktype-core version chore: update quicktype-core version May 29, 2024
@cmwylie19 cmwylie19 changed the title chore: update quicktype-core version fix: update quicktype-core version May 29, 2024
@cmwylie19 cmwylie19 merged commit f8cecdd into main May 29, 2024
12 checks passed
@cmwylie19 cmwylie19 deleted the 812-quicktype-bug-in-kfc branch May 29, 2024 20:17
Copy link

🎉 This PR is included in version 2.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

QuickType Bug in KFC
2 participants