Skip to content

Conversation

@mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Sep 18, 2025

Description

This PR adjusts the behavior around mapping/justifications on imports:

  1. Adjusts column order to match the control view (mappings after custom)
  2. Changes behavior so that mapping is an extra place to place a field, rather than moving it there. This allows for keeping the original field on a different tab, while also using it to auto-populate mapping justifications.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@mjnagel mjnagel self-assigned this Sep 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.11%. Comparing base (22171ed) to head (b2a053c).

Files with missing lines Patch % Lines
cli/server/spreadsheetRoutes.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   58.98%   59.11%   +0.12%     
==========================================
  Files          20       20              
  Lines        3672     3664       -8     
  Branches      451      451              
==========================================
  Hits         2166     2166              
+ Misses       1504     1496       -8     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjnagel mjnagel marked this pull request as ready for review September 18, 2025 14:25
@cmwylie19 cmwylie19 added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit 25d8995 Sep 18, 2025
12 checks passed
@github-actions
Copy link

🎉 This PR is included in version 0.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants