Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use env var for PR title in commitlint workflow to prevent untrusted script injection #60

Merged

Conversation

lucasrod16
Copy link
Contributor

Description

Our OSSF scorecard workflow flagged this as a Critical security risk. Unsure of whether there is a real attack vector in our specific case. Using an environment variable to capture untrusted input in workflows is a documented security hardening best practice by GitHub as well.

This should also boost our OSSF scorecard score since we have a 0 on this check.

image

Dangerous-Workflow check:

Risk of script injections:

Example script injection attack:

Recommended fix that this PR implements:

@Noxsios Noxsios merged commit c935607 into main Apr 5, 2024
6 checks passed
@Noxsios Noxsios deleted the fix-dangerous-workflow-detected-in-ossf-scorecard-analysis branch April 5, 2024 04:31
cmwylie19 pushed a commit to defenseunicorns/kubernetes-fluent-client that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants