Fix syntax error in tests#140
Closed
sc68cal wants to merge 1 commit into
Closed
Conversation
Member
|
Are you sure? All tests run fine for me. Tested python 2.5, 2.6, 2.7, 3.1 (after 2to3) and 3.2 |
Member
|
I just noticed that I did NOT test with 2.5 and you seem to have used 2.5 (according to your unittest path). I'll compile 2.5 and test again. Edit: Yes, Python2.5 seems to have a problem with the syntax. |
Contributor
Author
|
Sorry, I had my VirtualEnvs mixed up! Though, this is really a tiny issue in retrospect, since they're trying to move everyone up to 2.7 |
Member
|
Bottle does support 2.5, so it is a valid issue :) I'll merge as soon as I have the time to repair my testing environment. I normally test with 2.5, 2.6, 2.7, 3.1 and 3.2. The build-script seems to be broken for 2.5, though. |
Member
|
Cherry-Picked :) b20be42 Thanks. My test framework works again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think Python 2.5 prefers named parameters, then the _args and *_kwargs, when calling a function.