Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show on the tile select screen the ID of the tile #5941

Closed
Enigmanark opened this issue Jul 18, 2021 · 5 comments
Closed

Show on the tile select screen the ID of the tile #5941

Enigmanark opened this issue Jul 18, 2021 · 5 comments
Labels
editor Issues related to the Defold editor feature request A suggestion for a new feature good first issue? The issue might be good for beginners wanting to work on the engine or the editor tilemap Issues related to tilemaps

Comments

@Enigmanark
Copy link

It would be nice for those of us that use procgen to manipulate tilemaps if we could easily get the ID of a specific tile for use with tilemap.set_tile() this is the screen I'm talking about
Screenshot_1

Also I have made a post on the forums about it.
(https://forum.defold.com/t/suggestion-tilemap-selection-id/68880)

@Enigmanark Enigmanark added the feature request A suggestion for a new feature label Jul 18, 2021
@britzl britzl added editor Issues related to the Defold editor tilemap Issues related to tilemaps labels Jul 18, 2021
@AGulev AGulev added the good first issue? The issue might be good for beginners wanting to work on the engine or the editor label Aug 19, 2022
@andrewruales
Copy link

How can I begin working on this feature as a new contributor?

@britzl
Copy link
Contributor

britzl commented Sep 14, 2022

How can I begin working on this feature as a new contributor?

Thank you for showing an interest in contributing to Defold!

  1. Step one is to make sure you can build the editor. Please have a look at the setup instructions here: https://github.com/defold/defold/blob/dev/editor/README.md
  2. Once you have everything set up you can start contributing. Are you familiar with Clojure, the language most of the editor is written in?

@matgis and @vlaaad will provide some pointers to the relevant files and some getting started instructions!

@matgis
Copy link
Contributor

matgis commented Sep 14, 2022

I believe the "Cell 1, 1" string is produced here:
https://github.com/defold/defold/blob/dev/editor/src/clj/editor/tile_map.clj#L1144

You should be able to calculate the tile ID using the tile-dimensions that are also available there and add it to the string.

@andrewruales
Copy link

andrewruales commented Sep 30, 2022

It seems like I can rewrite this line with the x and y position of the cursor divided by the width and height of a tile. I have written this and would like to try opening a pull request but am receiving a "permission denied" message when trying to do so. What are your thoughts on this?

@britzl
Copy link
Contributor

britzl commented Sep 30, 2022

I have written this and would like to try opening a pull request but am receiving a "permission denied" message when trying to do so. What are your thoughts on this?

In order to create a pull request you need to first fork the repository to your own account. Once that is done and you have added and tested your changes you can create a pull request to the upstream repository (ie this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Issues related to the Defold editor feature request A suggestion for a new feature good first issue? The issue might be good for beginners wanting to work on the engine or the editor tilemap Issues related to tilemaps
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants