Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues-6327 Creating tilemaps through factories does not update collision for programmatically changed tiles #6329

Merged
merged 1 commit into from Jan 17, 2022
Merged

Issues-6327 Creating tilemaps through factories does not update collision for programmatically changed tiles #6329

merged 1 commit into from Jan 17, 2022

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Jan 15, 2022

fix #6327

@AGulev AGulev requested a review from britzl January 15, 2022 17:31
britzl
britzl approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right. I do wonder why it was done in the way it was. Are we missing something?

@AGulev
Copy link
Contributor Author

AGulev commented Jan 16, 2022

Looks about right. I do wonder why it was done in the way it was. Are we missing something?

it's a very good question, and I thought about it a lot. But I didn't find the answer.
This is commit that made this change c109693

It's not so informative.
I tested it a bit using different tilemaps in our examples and everything works fine.

The problem here, that init call happens earlier that AddToUpdate and SetupTileGrid called from AddToUpdate just overrides all the changes made in init() function.

@AGulev
Copy link
Contributor Author

AGulev commented Jan 16, 2022

maybe @JCash has any ideas?

@AGulev AGulev merged commit 6faed55 into dev Jan 17, 2022
@AGulev AGulev deleted the Issue-6327-tilegrid-collisionobject-from-factory branch January 17, 2022 08:57
@britzl britzl added this to In progress in 1.2.192 via automation Jan 24, 2022
@britzl britzl removed this from In progress in 1.2.192 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

@JCash JCash JCash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating tilemaps through factories does not update collision for programmatically changed tiles
3 participants
@AGulev @britzl @JCash