updated querystring

[juliangruber]

Updated querystring to the latest version + my fixes for browsers (see tj/node-querystring#57)

[defunctzombie]

Can we just instead use the node-querystring module like we use http-browserify?

[medikoo]

There's also https://github.com/Gozala/querystring which is a code mirror for Node's querystring

[juliangruber]

that module still needs some shims though

[medikoo]

what shims? what for? I use it without issues in browsers.

[juliangruber]

It uses Object.keys, Array.isArray and more. So it's an issue if you need support for IE<9 without polyfills.

[medikoo]

Yeah, if you need that, you load es5-shim before.

[juliangruber]

Nah, no polyfills for me plz

[medikoo]

@juliangruber without taking advantage of ES5 you're just locking yourself in year 2005.

[ghost]

@shtylman how about merging this now and then when somebody has a version on npm with the same fixes we can depend on that?

[juliangruber]

my PR on qs has already been merged, it just needs to be released.

[defunctzombie]

Since the PR on qs has been merged, I will wait for that to be released
(hoping that won't take too long). If someone could ping this PR when that
happens I can make the changes to use that module.

On Tue, Apr 23, 2013 at 9:00 AM, Julian Gruber notifications@github.comwrote:

my PR on qs has already been merged, it just needs to be released.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-16856337
.

[juliangruber]

ping ping ping :)

[defunctzombie]

Looking at the qs module. I don't see it being node.js compatible with the following:
http://nodejs.org/api/querystring.html#querystring_querystring_escape

Thoughts?

[juliangruber]

Oh, true....ok then I'll have to make https://github.com/Gozala/querystring run in older browsers...

[juliangruber]

Waiting for Gozala/querystring#4

[juliangruber]

So, Gozala doesn't want to merge my PR, because shims shouldn't be part of the code.

Either we say browserify requires polyfills or we include my fork: https://github.com/juliangruber/querystring/tree/compat.

[defunctzombie]

Since the other projects seem to be going nowhere, I will just merge this. We can deal with other issues as they come up.