Empty the ENV? #31

Closed
defunkt opened this Issue Nov 15, 2010 · 7 comments

Comments

Projects
None yet
7 participants
Owner

defunkt commented Nov 15, 2010

Should cijoe run tests with a clean ENV, leaving it up to the test script to set everything up?

This might(?) make it more difficult to easily setup tests, but will definitely stop unwanted environment mixups.

hehehe

gravis commented Nov 15, 2010

I always had issues running CIJOE, and especially with the ENV (https://github.com/defunkt/cijoe/issues#issue/23 => I suspect CIJOE tu run in production mode)
You should also never ever put your prod passwords in your repo or anywhere else than prod servers ;)

Owner

defunkt commented Feb 8, 2011

Empty the ENV before building. Closed by 194ff6d

mcolyer commented Feb 16, 2011

I'm not sure this is the right fix. If you clear ENV you remove PATH and HOME which are used by various things.

Also this won't clear the environment unless you have an after-reset file. Some projects do not have an after-reset file.

david commented Feb 18, 2011

I agree with mcolyer. This is totally the wrong way to do it. People should be responsible for setting up the environment cijoe runs on, it should not be cijoe's responsibility to clean up the environment for them. If you want to control the environment cijoe runs in, create a new user and run cijoe as that user, or let them run cijoe with env -i.

@ghost

ghost commented May 24, 2011

This seems to only clear the environment when you have an after-reset file. Was hoping to use after-reset to run "bundle install", but it is making life difficult.

priit pushed a commit to priit/cijoe that referenced this issue Aug 9, 2011

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment