Include things like github.com/foo.js or janl/github.com.js #85

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@agnoster

Example: suppose djsd receives a GET /github.com.js

Previously, we would only look for ~/.js/github.com.js. Now, the following would also appear (if present):

  • ~/.js/github.com/pull-request-edit-button.js
  • ~/.js/janl/github.com.js
  • ~/.js/janl/github.com/gpl-warning.js

This should make it easier to share and fork repos of dotjs files, as well as
putting features into their own "bundles" (inspired slightly by vim's pathogen).

(I also updated the chrome installation instructions - Google broke that a some point. Thanks, Google! Thgoogle.)

agnoster added some commits Oct 17, 2012

Update information for installing .crx extension
Google has changed - sometime in the last months - that you can no longer install a .crx file simply by dragging it onto Chrome: it tells you that you can only install extensions from the Chrome Web Store.

You can bypass this restriction by dragging the file onto the list of extensions in chrome://extensions, so I've updated the test in the Rake task to reflect that.
Include directories as well as files
Example: localhost:3131/github.com.js

Previously, we would only look for `~/.js/github.com.js`. Now, the following would also appear (if present):

* `~/.js/github.com/pull-request-edit-button.js`
* `~/.js/janl/github.com.js`
* `~/.js/janl/github.com/gpl-warning.js`

This should make it easier to share and fork repos of dotjs files, as well as
putting features into their own "bundles" (inspired slightly by vim's pathogen).
@johan

This comment has been minimized.

Show comment
Hide comment
@johan

johan Oct 20, 2012

Contributor

While I understand how you think, randomly mixing semantically named directory levels with non-semantic ones will have lots of bad interactions; say, including a bundle from some guy named "com", "info" or "museum", for instance.

Those would both run on the domains where his dns-semantically named subdirectories match, and on google.com, blog.persistent.info and guggenheim.museum respectively.

Something like johan/dotjs@0881164 is way safer.

Contributor

johan commented Oct 20, 2012

While I understand how you think, randomly mixing semantically named directory levels with non-semantic ones will have lots of bad interactions; say, including a bundle from some guy named "com", "info" or "museum", for instance.

Those would both run on the domains where his dns-semantically named subdirectories match, and on google.com, blog.persistent.info and guggenheim.museum respectively.

Something like johan/dotjs@0881164 is way safer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment