Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to pay-order URL instead of checkout #62

Merged
merged 3 commits into from Jun 28, 2022

Conversation

Resonious
Copy link
Member

@Resonious Resonious commented Jun 23, 2022

There are some stores that expire the checkout as soon as the user begins payment. Right now, this plugin returns the user to checkout when they click "return to merchant" on KOMOJU. For stores that expire the checkout, this behavior shows an error when the user tries to return to the store.

This PR changes the plugin behavior. Instead of returning to checkout, we now return to the pay-order page for the existing order (this is pretty subtle, honestly. there's barely any difference on the default development store).

woocommerce-pay-order-screen.mp4

To test

  1. Start a payment through WooCommerce
  2. Click "back to merchant" from the KOMOJU session page
  3. You should be back on the store, but not the checkout. Your url should include "pay-order".

@degicat
Copy link

degicat commented Jun 27, 2022

@Iorin0225 can you help us review this PR, please?

@degicat degicat requested a review from Iorin0225 June 27, 2022 04:33
Copy link
Contributor

@Iorin0225 Iorin0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Btw, I love the new way to connect with KOMOJU 😄

@Iorin0225 Iorin0225 merged commit abe0c4b into master Jun 28, 2022
@Iorin0225 Iorin0225 deleted the return-to-pay-order-url branch June 28, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants