Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-insertion of threat description broken #131

Closed
matthewejones opened this issue Aug 9, 2021 · 2 comments · Fixed by #136
Closed

Auto-insertion of threat description broken #131

matthewejones opened this issue Aug 9, 2021 · 2 comments · Fixed by #136
Labels
bug Something isn't working

Comments

@matthewejones
Copy link
Contributor

When you created a threat when playing elevation of privilege it automatically took the description off the card as the default description for the threat. It might be nice to also implement this for cornucopia.

This is defined in src/game/definitions.js

@ChristophNiehoff ChristophNiehoff changed the title Cornucopia threat description Auto-insertion of threat description broken Aug 9, 2021
@ChristophNiehoff
Copy link
Collaborator

Actually, it is more than that: The strings in src/game/definitions.js are still indexed using the old (STRIDE-based) card names. As a result, auto-insertion of the threat description is even broken for EoP right now...

@ChristophNiehoff ChristophNiehoff added the bug Something isn't working label Aug 9, 2021
@ChristophNiehoff
Copy link
Collaborator

But for Cornucopia I am not so sure, if this helps so much. The descriptions on the cards are rather lengthy and always start with some hacker name that you don't want to write down in an serious report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants