From 2e37e99073cf07043726186982397e8fdb115b81 Mon Sep 17 00:00:00 2001 From: helgi Date: Fri, 2 Sep 2016 11:38:14 -0700 Subject: [PATCH] fix(scheduler): pass down the right variable for Deployment revision history limit Prior to this the wrong variable was being passed and as such the revision history feature did not work --- rootfs/api/models/app.py | 2 +- rootfs/scheduler/resources/deployment.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rootfs/api/models/app.py b/rootfs/api/models/app.py index 338b28941..ea05e761d 100644 --- a/rootfs/api/models/app.py +++ b/rootfs/api/models/app.py @@ -540,7 +540,7 @@ def deploy(self, release, force_deploy=False): 'routable': routable, 'deploy_batches': batches, 'deploy_timeout': deploy_timeout, - 'deployment_history_limit': deployment_history, + 'deployment_revision_history_limit': deployment_history, 'release_summary': release.summary, 'pod_termination_grace_period_seconds': pod_termination_grace_period_seconds, 'image_pull_secret_name': image_pull_secret_name, diff --git a/rootfs/scheduler/resources/deployment.py b/rootfs/scheduler/resources/deployment.py index 25552db6a..d7e2c4f60 100644 --- a/rootfs/scheduler/resources/deployment.py +++ b/rootfs/scheduler/resources/deployment.py @@ -94,8 +94,8 @@ def manifest(self, namespace, name, image, entrypoint, command, **kwargs): } # Add in how many deployment revisions to keep - if kwargs.get('deployment_revision_history', None) is not None: - manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history')) # noqa + if kwargs.get('deployment_revision_history_limit', None) is not None: + manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history_limit')) # noqa # tell pod how to execute the process kwargs['command'] = entrypoint