New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch into vpc #1028

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@rgarcia
Contributor

rgarcia commented May 22, 2014

Modifies the cloudformation configuration to create resources within the
confines of a VPC.

fixes #1005

feat(contrib/ec2): launch into vpc
Modifies the cloudformation configuration to create resources within the
confines of a VPC.

fixes #1005
@rgarcia

This comment has been minimized.

Show comment
Hide comment
@rgarcia

rgarcia May 22, 2014

Contributor

@carmstrong the approach you suggested in #1006 (comment)

Contributor

rgarcia commented May 22, 2014

@carmstrong the approach you suggested in #1006 (comment)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 22, 2014

Coverage Status

Coverage remained the same when pulling 349774e on Clever:vpc-config into 0212030 on deis:master.

coveralls commented May 22, 2014

Coverage Status

Coverage remained the same when pulling 349774e on Clever:vpc-config into 0212030 on deis:master.

@carmstrong

This comment has been minimized.

Show comment
Hide comment
@carmstrong

carmstrong May 22, 2014

Contributor

This is exactly what I was thinking @rgarcia - nice work! Code LGTM, but I haven't tested this by hand.

Contributor

carmstrong commented May 22, 2014

This is exactly what I was thinking @rgarcia - nice work! Code LGTM, but I haven't tested this by hand.

@mboersma mboersma added this to the 0.10.0 milestone May 30, 2014

@aaronfay

This comment has been minimized.

Show comment
Hide comment
@aaronfay

aaronfay Jun 11, 2014

@rgarcia it might be worth mentioning that I had to add the region for Resources:CoreOSServerAutoScale:Properties:AvailabilityZones in the deis.template file in order for the CloudFormation stack to create properly:

    "CoreOSServerAutoScale": {
      "Type": "AWS::AutoScaling::AutoScalingGroup",
      "Properties": {
        "AvailabilityZones": {"Fn::GetAZs": "us-west-2b"},
        ...
      }
    },

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

aaronfay commented Jun 11, 2014

@rgarcia it might be worth mentioning that I had to add the region for Resources:CoreOSServerAutoScale:Properties:AvailabilityZones in the deis.template file in order for the CloudFormation stack to create properly:

    "CoreOSServerAutoScale": {
      "Type": "AWS::AutoScaling::AutoScalingGroup",
      "Properties": {
        "AvailabilityZones": {"Fn::GetAZs": "us-west-2b"},
        ...
      }
    },

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

@carmstrong carmstrong removed their assignment Jun 12, 2014

@carmstrong

This comment has been minimized.

Show comment
Hide comment
@carmstrong

carmstrong Jun 24, 2014

Contributor

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

I'm really hoping we can use an AWS function like Fn::GetAZs (which you mentioned) to dynamically get the AZ of the launched instances.

Contributor

carmstrong commented Jun 24, 2014

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

I'm really hoping we can use an AWS function like Fn::GetAZs (which you mentioned) to dynamically get the AZ of the launched instances.

@carmstrong

This comment has been minimized.

Show comment
Hide comment
@carmstrong

carmstrong Jun 30, 2014

Contributor

I think I fixed the launching into a VPC as of #1232 - everyone who ran into trouble using this branch, please try that one.

Contributor

carmstrong commented Jun 30, 2014

I think I fixed the launching into a VPC as of #1232 - everyone who ran into trouble using this branch, please try that one.

@carmstrong carmstrong closed this Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment