launch into vpc #1028

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@rgarcia
Contributor
rgarcia commented May 22, 2014

Modifies the cloudformation configuration to create resources within the
confines of a VPC.

fixes #1005

@rgarcia rgarcia feat(contrib/ec2): launch into vpc
Modifies the cloudformation configuration to create resources within the
confines of a VPC.

fixes #1005
349774e
@rgarcia
Contributor
rgarcia commented May 22, 2014

@carmstrong the approach you suggested in #1006 (comment)

@coveralls

Coverage Status

Coverage remained the same when pulling 349774e on Clever:vpc-config into 0212030 on deis:master.

@carmstrong
Contributor

This is exactly what I was thinking @rgarcia - nice work! Code LGTM, but I haven't tested this by hand.

@mboersma mboersma added this to the 0.10.0 milestone May 30, 2014
@carmstrong carmstrong was assigned by mboersma May 30, 2014
@aaronfay

@rgarcia it might be worth mentioning that I had to add the region for Resources:CoreOSServerAutoScale:Properties:AvailabilityZones in the deis.template file in order for the CloudFormation stack to create properly:

    "CoreOSServerAutoScale": {
      "Type": "AWS::AutoScaling::AutoScalingGroup",
      "Properties": {
        "AvailabilityZones": {"Fn::GetAZs": "us-west-2b"},
        ...
      }
    },

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

@carmstrong carmstrong removed their assignment Jun 12, 2014
@carmstrong
Contributor

I'm not sure if this is always the case, but I kept getting an error saying AutoScalingGroup AZ and VPC AZ don't match. I also haven't figured out if this can be added to the cloudformation.json as a parameter (or how).

I'm really hoping we can use an AWS function like Fn::GetAZs (which you mentioned) to dynamically get the AZ of the launched instances.

@carmstrong
Contributor

I think I fixed the launching into a VPC as of #1232 - everyone who ran into trouble using this branch, please try that one.

@carmstrong carmstrong closed this Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment