From 7cfe4521615af4fe4b60eeae052ee85202c07081 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@riseup.net>
Date: Fri, 28 Dec 2018 19:54:26 +0100
Subject: [PATCH] Login before pushing image

---
 Rakefile          |  1 +
 docker/manager.rb | 34 +++++++++++++++++-----------------
 2 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/Rakefile b/Rakefile
index 2aedb2a78..1077cc672 100644
--- a/Rakefile
+++ b/Rakefile
@@ -115,6 +115,7 @@ namespace :docker do
     )
 
     manager.build
+    manager.login
     manager.push
   end
 
diff --git a/docker/manager.rb b/docker/manager.rb
index e7ca9e7bf..be372e0de 100644
--- a/docker/manager.rb
+++ b/docker/manager.rb
@@ -34,6 +34,21 @@ def initialize(version:, line_editor:, compiler:)
       @compiler = compiler
     end
 
+    def login
+      print "Logging in to dockerhub... "
+
+      login_cmd = %W[
+        docker
+        login
+        -u
+        #{ENV['DOCKER_USER']}
+        -p
+        #{ENV['DOCKER_PASS']}
+      ]
+
+      run(*login_cmd)
+    end
+
     def build
       command = <<-COMMAND
         docker build \
@@ -119,21 +134,6 @@ def run(*command)
 
       private
 
-      def login
-        print "Logging in to dockerhub... "
-
-        login_cmd = %W[
-          docker
-          login
-          -u
-          #{ENV['DOCKER_USER']}
-          -p
-          #{ENV['DOCKER_PASS']}
-        ]
-
-        run(*login_cmd)
-      end
-
       def releases_url
         "https://raw.githubusercontent.com/ruby/www.ruby-lang.org/master/_data/releases.yml"
       end
@@ -196,8 +196,8 @@ def download_sha256
       version_info["sha256"]["xz"]
     end
 
-    def run(command)
-      self.class.run(command)
+    def run(*command)
+      self.class.run(*command)
     end
 
     def tag