Skip to content

Commit

Permalink
Drop ruby 2.3 support (#554)
Browse files Browse the repository at this point in the history
  • Loading branch information
deivid-rodriguez committed Apr 27, 2019
1 parent 3a9f402 commit d16d829
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 46 deletions.
37 changes: 0 additions & 37 deletions .circleci/config.yml
Expand Up @@ -146,38 +146,6 @@ workflows:

test:
jobs:
- spec:
name: 2.3-readline-gcc
executor:
name: test
version: 2.3.8
line_editor: readline
compiler: gcc

- spec:
name: 2.3-libedit-gcc
executor:
name: test
version: 2.3.8
line_editor: libedit
compiler: gcc

- spec:
name: 2.3-readline-clang
executor:
name: test
version: 2.3.8
line_editor: readline
compiler: clang

- spec:
name: 2.3-libedit-clang
executor:
name: test
version: 2.3.8
line_editor: libedit
compiler: clang

- spec:
name: 2.4-readline-gcc
executor:
Expand Down Expand Up @@ -308,11 +276,6 @@ workflows:

- upload_coverage:
requires:
- 2.3-readline-gcc
- 2.3-libedit-gcc
- 2.3-readline-clang
- 2.3-libedit-clang

- 2.4-readline-gcc
- 2.4-libedit-gcc
- 2.4-readline-clang
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Expand Up @@ -7,7 +7,7 @@ AllCops:
DisplayCopNames: true
DisplayStyleGuide: true

TargetRubyVersion: 2.3
TargetRubyVersion: 2.4

Layout/ExtraSpacing:
AllowForAlignment: false
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Removed

* Support for MRI 2.3. Byebug no longer installs on this platform.

## [11.0.1] - 2019-03-18

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -47,7 +47,7 @@ Windows [![Vey][vey]][vey_url]

## Requirements

MRI 2.3.0 or higher.
MRI 2.4.0 or higher.

## Install

Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
Expand Up @@ -38,7 +38,6 @@ test_script:

environment:
matrix:
- ruby_version: 23-x64
- ruby_version: 24-x64
- ruby_version: 25-x64
- ruby_version: 26-x64
Expand Down
2 changes: 1 addition & 1 deletion byebug.gemspec
Expand Up @@ -20,7 +20,7 @@ Gem::Specification.new do |s|
can build on. It provides breakpoint handling and bindings for stack frames
among other things and it comes with an easy to use command line interface."

s.required_ruby_version = ">= 2.3.0"
s.required_ruby_version = ">= 2.4.0"

s.files = Dir["lib/**/*.rb", "lib/**/*.yml", "ext/**/*.[ch]", "LICENSE"]
s.bindir = "exe"
Expand Down
1 change: 0 additions & 1 deletion docker/manager.rb
Expand Up @@ -10,7 +10,6 @@ module Docker
#
class Manager
VERSIONS = %w[
2.3.8
2.4.5
2.5.5
2.6.2
Expand Down
2 changes: 1 addition & 1 deletion lib/byebug/commands/set.rb
Expand Up @@ -50,7 +50,7 @@ def execute
if !setting.boolean? && value.nil?
err = pr("set.errors.must_specify_value", key: key)
elsif setting.boolean?
value, err = get_onoff(value, key =~ /^no/ ? false : true)
value, err = get_onoff(value, /^no/.match?(key) ? false : true)
elsif setting.integer?
value, err = get_int(value, setting.to_sym, 1)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/byebug/setting.rb
Expand Up @@ -52,7 +52,7 @@ def []=(name, value)
end

def find(shortcut)
abbr = shortcut =~ /^no/ ? shortcut[2..-1] : shortcut
abbr = /^no/.match?(shortcut) ? shortcut[2..-1] : shortcut
matches = settings.select do |key, value|
key =~ (value.boolean? ? /#{abbr}/ : /#{shortcut}/)
end
Expand Down
2 changes: 1 addition & 1 deletion test/commands/where_test.rb
Expand Up @@ -120,7 +120,7 @@ def test_where_displays_instance_exec_block_frames
# are usually very deeply nested and on OS X where tmp path is always
# deeply nested.
#
unless /cygwin|mswin|mingw|darwin/ =~ RUBY_PLATFORM
unless /cygwin|mswin|mingw|darwin/.match?(RUBY_PLATFORM)
class WhereWithNotDeeplyNestedPathsTest < WhereStandardTest
def test_where_displays_current_backtrace_w_shorpaths_if_fullpath_disabled
enter "set nofullpath", "where", "set fullpath"
Expand Down
2 changes: 1 addition & 1 deletion test/minitest_runner.rb
Expand Up @@ -48,7 +48,7 @@ def test_suites
end

def test_methods(str)
if str =~ /test_.*/
if /test_.*/.match?(str)
filter_runnables_by_method(str)
else
filter_runnables_by_class(str)
Expand Down

0 comments on commit d16d829

Please sign in to comment.