Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11.1.2 regression #674

Merged
merged 1 commit into from Apr 23, 2020
Merged

Fix 11.1.2 regression #674

merged 1 commit into from Apr 23, 2020

Conversation

@deivid-rodriguez
Copy link
Owner

deivid-rodriguez commented Apr 22, 2020

Fixes #673.

@deivid-rodriguez deivid-rodriguez changed the title Add 2.7.0 testing on Windows Fix 11.1.2 regression Apr 22, 2020
By default ruby 2.7.0 on Windows comes with rb-readline, which doesn't
like `nil` completion procs, and with a version of `irb` that installs
its own completion proc.

That combination causes `byebug` to crash.

Installing a dummy "nil proc" seems like the most compatible thing to
do.
@deivid-rodriguez deivid-rodriguez force-pushed the fix_regression branch from 4e02619 to 721b5a9 Apr 22, 2020
@deivid-rodriguez deivid-rodriguez merged commit 2d43b0c into master Apr 23, 2020
23 checks passed
23 checks passed
install_and_run
Details
test (2.4.9, libedit, clang)
Details
test (2.4.9)
Details
test (2.4.9, libedit, gcc)
Details
test (2.5.7)
Details
test (2.4.9, readline, clang)
Details
test (2.6.5)
Details
test (2.4.9, readline, gcc)
Details
test (2.7.0)
Details
test (2.5.7, libedit, clang)
Details
test (head)
Details
test (2.5.7, libedit, gcc)
Details
test (2.5.7, readline, clang)
Details
test (2.5.7, readline, gcc)
Details
test (2.6.5, libedit, clang)
Details
test (2.6.5, libedit, gcc)
Details
test (2.6.5, readline, clang)
Details
test (2.6.5, readline, gcc)
Details
test (2.7.0, libedit, clang)
Details
test (2.7.0, libedit, gcc)
Details
test (2.7.0, readline, clang)
Details
test (2.7.0, readline, gcc)
Details
coverage
Details
@deivid-rodriguez deivid-rodriguez deleted the fix_regression branch Apr 23, 2020
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 27, 2020
Update ruby-byebug to 11.1.3.


## [11.1.3] - 2020-04-23

### Fixed

* [#674](deivid-rodriguez/byebug#674): crash when using byebug on ruby 2.7.0 on Windows.

## [11.1.2] - 2020-04-17

### Fixed

* [#657](deivid-rodriguez/byebug#657): crash when hitting \<TAB\> due to IRB completion mechanism included in the default ruby 2.7 version of the `irb` gem ([@terceiro]).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.