Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve breakpoint on method within context #17

Merged
merged 5 commits into from Jan 24, 2014

Conversation

palkan
Copy link
Contributor

@palkan palkan commented Jan 21, 2014

Hi!
Previous PR fixes breakpoints on method calls which are explicitly set with class/module name.
But if we want to add breakpoint on method within context (= instance method of current object's class) we should write 'break #call' (as we write 'break 10' with line number).

The PR adds this functionality.

@deivid-rodriguez
Copy link
Owner

@deivid-rodriguez deivid-rodriguez commented Jan 22, 2014

Hi @palkan!

Could you please add another test for the functionality your're adding, say test_add_method_adds_class_method_breakpoint_within_context. It should be pretty similar to the ones added in previous PR.

If you can't, I'll review this as soon as possible. Otherwise the test should be enough and I'll merge it straight away.

Thanks for this!

@palkan
Copy link
Contributor Author

@palkan palkan commented Jan 23, 2014

Hi!
I've added tests for different break ... commands including break #method in test/commands_test.rb.

deivid-rodriguez added a commit that referenced this issue Jan 24, 2014
Improve breakpoint on method within context
@deivid-rodriguez deivid-rodriguez merged commit bbafe54 into deivid-rodriguez:master Jan 24, 2014
1 check passed
@palkan palkan deleted the hotfix branch Jan 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants