Improve breakpoint on method within context #17

Merged
merged 5 commits into from Jan 24, 2014

Conversation

Projects
None yet
2 participants
@palkan
Contributor

palkan commented Jan 21, 2014

Hi!
Previous PR fixes breakpoints on method calls which are explicitly set with class/module name.
But if we want to add breakpoint on method within context (= instance method of current object's class) we should write 'break #call' (as we write 'break 10' with line number).

The PR adds this functionality.

@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Jan 22, 2014

Owner

Hi @palkan!

Could you please add another test for the functionality your're adding, say test_add_method_adds_class_method_breakpoint_within_context. It should be pretty similar to the ones added in previous PR.

If you can't, I'll review this as soon as possible. Otherwise the test should be enough and I'll merge it straight away.

Thanks for this!

Owner

deivid-rodriguez commented Jan 22, 2014

Hi @palkan!

Could you please add another test for the functionality your're adding, say test_add_method_adds_class_method_breakpoint_within_context. It should be pretty similar to the ones added in previous PR.

If you can't, I'll review this as soon as possible. Otherwise the test should be enough and I'll merge it straight away.

Thanks for this!

@palkan

This comment has been minimized.

Show comment
Hide comment
@palkan

palkan Jan 23, 2014

Contributor

Hi!
I've added tests for different break ... commands including break #method in test/commands_test.rb.

Contributor

palkan commented Jan 23, 2014

Hi!
I've added tests for different break ... commands including break #method in test/commands_test.rb.

deivid-rodriguez added a commit that referenced this pull request Jan 24, 2014

Merge pull request #17 from palkan/hotfix
Improve breakpoint on method within context

@deivid-rodriguez deivid-rodriguez merged commit bbafe54 into deivid-rodriguez:master Jan 24, 2014

1 check passed

default The Travis CI build passed
Details

@palkan palkan deleted the palkan:hotfix branch Jan 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment