fix problems with safe strings #48

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@emiltin

emiltin commented Jun 12, 2012

using gsub on safe strings doesn't work - $1, $2, are empty. to avoid this, use to_str, as well as to_s before passing to filters.

using to_str alone could be a problem, since it will not convert nil to "", but fail, so use to_s.to_str

@dejan

This comment has been minimized.

Show comment
Hide comment
@dejan

dejan Jul 28, 2012

Owner

I can't reproduce the problem. Can you please provide a test or an example? Thanks.

Owner

dejan commented Jul 28, 2012

I can't reproduce the problem. Can you please provide a test or an example? Thanks.

@emiltin

This comment has been minimized.

Show comment
Hide comment
@emiltin

emiltin Jul 29, 2012

maybe a difference between ruby 1.9 and 1.8?

emiltin commented Jul 29, 2012

maybe a difference between ruby 1.9 and 1.8?

@dejan

This comment has been minimized.

Show comment
Hide comment
@dejan

dejan Jan 3, 2014

Owner

As I said, I can't reproduce the problem. Please provide failing test that this change would fix it.

Owner

dejan commented Jan 3, 2014

As I said, I can't reproduce the problem. Please provide failing test that this change would fix it.

@emiltin

This comment has been minimized.

Show comment
Hide comment
@emiltin

emiltin Jan 3, 2014

I'll see if I can find the time. But to be clear, by safe string I mean the rails ActiveSupport::SafeBuffer http://api.rubyonrails.org/classes/ActiveSupport/SafeBuffer.html

emiltin commented Jan 3, 2014

I'll see if I can find the time. But to be clear, by safe string I mean the rails ActiveSupport::SafeBuffer http://api.rubyonrails.org/classes/ActiveSupport/SafeBuffer.html

@emiltin emiltin referenced this pull request in ibikecph/ibikecph-site Nov 12, 2014

Closed

Forked gems and hacks still necessary? #4

@dejan

This comment has been minimized.

Show comment
Hide comment
@dejan

dejan Feb 7, 2015

Owner

Closing this, since there are no steps to reproduce the issue.

Owner

dejan commented Feb 7, 2015

Closing this, since there are no steps to reproduce the issue.

@dejan dejan closed this Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment